Closed
Bug 1033951
Opened 10 years ago
Closed 10 years ago
[Settings] Allow Settings app embed a app in its own process
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: arthurcc, Assigned: eragonj)
References
Details
(Whiteboard: [p=2])
Attachments
(1 file)
This bug could be seen as the first step of resolving bug 1020063. We should provide a way of embedding another app in settings app. Before nested oop (bug 1020135) completes this cannot be utilized by 3rd-party apps. However, once bug 1020135 lands, it should be easy to embed the app out of process by adding the remote attribute.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8450067 [details]
patch on master
Hi Arthur,
can you help me review this patch ?! Thanks :)
Attachment #8450067 -
Flags: review?(arthur.chen)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8450067 [details]
patch on master
Thank you for the patch, EJ. I've left a few comments regarding the naming and comments. Please also add test cases ensuring it navigates to the iframe panel correctly when passing a app url.
Attachment #8450067 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8450067 [details]
patch on master
Hi Arthur,
I just added tests and addressed your comments ! Please help me take a took again when you have time. Big thanks !
Attachment #8450067 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=2]
Target Milestone: --- → 2.1 S1 (1aug)
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8450067 [details]
patch on master
r=me, thank you!
Attachment #8450067 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks all, this patch was landed on Gaia/master : https://github.com/mozilla-b2g/gaia/commit/20c6f80f9b708b23f3ae9b91089da810c3e0f4f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•