Per AOSP design (see [1]), AP does not need to send TR to modem for below four cases. Some modem will be malfunction if we send TR for those types of proactive command. And, re-plug in battery will be the only solution to recover. 1. STK_CMD_SEND_SS 2. STK_CMD_SEND_USSD 3. STK_CMD_SEND_SMS 4. STK_CMD_SEND_DTMF There is an on-line document (see [2]) talking about this too. [1] - https://github.com/android/platform_packages_apps_stk/blob/master/src/com/android/stk/StkAppService.java#L436 [2] - http://www.kandroid.org/online-pdk/guide/stk.html

Hi Jose: Could we have your comment here first? Thanks!! Shawn

Hi Fernando: Could you please help check if we can simply remove the TR for SS/USSD/SMS/DTMF? or We still need to revise related test cases? https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L89 https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L109 https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L124

(In reply to shawn ku [:sku] from comment #2) > Hi Fernando: > Could you please help check if we can simply remove the TR for > SS/USSD/SMS/DTMF? or We still need to revise related test cases? > > https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker. > js#L89 > https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker. > js#L109 > https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker. > js#L124 Sure! I did a PR: https://github.com/mozilla-b2g/gaia/pull/25525 Is it working well? Can you check it?

Comment on attachment 8511848 [details] Proposed patch hi Fernando: This PR is exactly the same as I did for partner on 1.3t/1.4. (The patch was provided by diff based due to time pressure) Thanks for your prompt response. Shawn

Comment on attachment 8511848 [details] Proposed patch Based on comment 5, and the fact that Vivien is out for a bit, I will go ahead and review stamp this for you. To be honest, I don't entirely know this code too well, but since :sku has provided feedback this seems fine. Please make sure this gets into master, I'm not sure why we took this on a partner branch but not master. That should not happen in the future.

(In reply to Kevin Grandon :kgrandon from comment #6) > Comment on attachment 8511848 [details] > Proposed patch > > Based on comment 5, and the fact that Vivien is out for a bit, I will go > ahead and review stamp this for you. To be honest, I don't entirely know > this code too well, but since :sku has provided feedback this seems fine. > > Please make sure this gets into master, I'm not sure why we took this on a > partner branch but not master. That should not happen in the future. Ok Kevin. Thank you ! I'll rebase it to land in master.

Hi Kai-Zhen, Could you help to land this patch on 2.0M? Thanks!

Merge patch into master or 2.0m get conflicts. Fernando, could you help to rebase the patch? Thanks!

Hi, Yes, I'll merge on 2.0m and master. Thank you (In reply to Kai-Zhen Li [:seinlin] from comment #9) > Merge patch into master or 2.0m get conflicts. > > Fernando, could you help to rebase the patch? Thanks!

Landed. Master: https://github.com/mozilla-b2g/gaia/commit/cb3e85a9a4a2f3521ee07fbce9eebf86a9614041 2.0m: https://github.com/mozilla-b2g/gaia/commit/8e17537f9e6d02b7271d92134671414d1fb88386

Fernando, Thanks!