Bug #944615 only works for ICS emulator. We need an equivalent patch for JB and KK. Code for JB: https://github.com/mozilla-b2g/device_generic_goldfish/blob/b2g-4.3_r2.1/audio/audio_hw.c#L538 Code for KK: https://github.com/mozilla-b2g/device_generic_goldfish/blob/b2g-4.4.2_r1/audio/audio_hw.c#L538

We need to find a way to land the patch for libhardware_legacy; either fork the repo from AOSP, or making a build-time patch.

@mwu, may I know your opinion about how to land code in libhardware_legacy?

Fork it.

Comment on attachment 8455195 [details] patch for device/generic/goldfish/ Looks fine but one nit.

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #8) > Comment on attachment 8455195 [details] > patch for device/generic/goldfish/ > > Looks fine but one nit. Patch updated. I don't have time recently to write the patch for manifest.xml. We could merge these two pull requests first so that people who has the need of testing WebRTC on emulator jb/kk can manually merge the change to there local repo. I'll open a follow-up bug for the manifest.xml change.

Don't know how to verify this because 1) I can't run mochitest locally due to bug 1002545, 2) try server does not run mochitest on emulator-jb, emulator-kk targets.

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #12) > Don't know how to verify this because 1) I can't run mochitest locally due > to bug 1002545, 2) try server does not run mochitest on emulator-jb, > emulator-kk targets. The workaround for 1) is copy ssltunnel from your Firefox build folder (m-c/objdir/dist/bin) to gaia sdk folder (b2g/gaia/xulrunner-sdk-33/xulrunner-sdk/bin/XUL.framework/Versions/Current/).

Both emulator-jb & emulator-kk are verified. Waiting for bug 1059104.

Comment on attachment 8479678 [details] Github pull request for b2g-manifest Fork hardware/libhardware_legacy for emulator-jb/kk. All other targets remain tracking to AOSP libhardware_legacy. This pull request removes libhardware_legacy from base-jb and base-kk, and re-add libhardware_legacy back corresponding project to their descendants. base-jb (removed libhardware_legacy) +-> nexus-4 (add libhardware_legacy from AOSP) +-> flo (add libhardware_legacy from AOSP) +-> emulator-jb (add libhardware_legacy from Mozilla) base-kk (removed libhardware_legacy) +-> base-kk-caf (add libhardware_legacy from AOSP) +-> base-kk-aosp +-> nexus-4-kk (add libhardware_legacy from AOSP) +-> nexus-5 (add libhardware_legacy from AOSP) +-> emulator-kk (add libhardware_legacy from Mozilla) +-> dolphin (add libhardware_legacy from AOSP) Verified fetching works correctly on emulator-jb & kk.

Comment on attachment 8479678 [details] Github pull request for b2g-manifest For kk manifests, you'll want to use remove-project to override the default repo in base-kk-aosp.xml rather than add the new repo in every device.

(In reply to Michael Wu [:mwu] from comment #16) > Comment on attachment 8479678 [details] > Github pull request for b2g-manifest > > For kk manifests, you'll want to use remove-project to override the default > repo in base-kk-aosp.xml rather than add the new repo in every device. But why do we have a condition "for kk manifests" here? Repo has nothing to do with the release version of the contents. We're using the same repo for all release versions, aren't we?

It's just a different convention on kk manifests. On JB, when an AOSP repo needs to fork, that also requires the base-jb-caf.xml manifest to be changed since that repo is removed from base-jb.xml. Starting with base-kk*, when we fork an AOSP repo, we only need to change things in base-kk-aosp because we remove the project in base-kk-aosp.xml rather than in base-kk.xml. We can backport this style to base-jb for consistency.

Comment on attachment 8479678 [details] Github pull request for b2g-manifest Addressed review comment 16.

Comment on attachment 8479678 [details] Github pull request for b2g-manifest Verified on my local machine. libhardware_legacy pulls http://github.com/mozilla-b2g/android-hardware_legacy after applying this patch.