browser_ruleview_completion-new-property_02.js

Reported in this try build logs: https://tbpl.mozilla.org/php/getParsedLog.php?id=42847190&tree=Try&full=1 Like most of the failures reported there, it's not reported on the right test: browser_ruleview_content_01.js | A promise chain failed to handle a rejection - unknownError ==> Is in fact a unhandled rejected promise from the previous test: browser_ruleview_completion-new-property_02.js but reported late in browser_ruleview_content_01.js. I've been fixing a few similar bugs in the past days and one of the fix actually helped get rid of this one (probably due to bug 1026395 or bug 1026392). Still this test modifies properties of the test element's inline style, which should be changed to a stylesheet rule instead to avoid triggering markup mutations during the test.

Pending try build: https://tbpl.mozilla.org/?tree=Try&rev=4daa01469320

Comment on attachment 8450109 [details] [diff] [review] bug1034004-unhandled-rejected-promise-browser_ruleview_completion-new-property_02.js.patch Review of attachment 8450109 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine if it gets rid of the rejection. I can't help but think that we need to find a better generic solution for this (which seems to be something like markup mutations arriving late, after the document has changed). Because this could surely also happen during normal toolbox usage. Regardless, the change is fine with me.

Green try. Pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/d9d1653a0f01