Closed
Bug 1034210
Opened 10 years ago
Closed 10 years ago
[B2G][Keyboard] The characters on the Tamil Keyboard do not match what is seen on www.branah.com
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:2.0+, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: dharris, Assigned: rudyl)
References
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
timdream
:
review+
bajaj
:
approval-gaia-v1.4+
|
Details |
(deleted),
image/png
|
Details |
Description:
The keyboard that is shown on the DUT does not match the same layout as what is shown on http://www.branah.com/tamilinscript. Also when the shift key is active and the keyboard is populated with new characters, the user is unable to type any of the new characters.
Pre-req: Use 'GAIA_KEYBOARD_LAYOUTS=ko make reset-gaia' to add the Tamil keyboard to the build
Repro Steps:
1) Update a Flame to BuildID: 20140702000201
2) Open Settings App> Keyboards> Selected Keyboards
3) Select 'Add more keyboards'
4) Tap on Tamil to select> tap on English to deselect
5) Go to Homescreen> Open Messages App
6) Select Compose new message icon> Observe Keyboard layout compared to http://www.branah.com/tamilinscript
7) Tap the shift key> Try to type a newly populated characters
Actual:
The keyboard layout on the DUT does not match http://www.branah.com/tamilinscript. Also none of the characters that populate with shift active will be type-able
Expected:
Keyboard layout is correct for the Tamil language and all the characters have the ability to be typed
Environmental Variables:
Device: Flame 2.0
BuildID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/12392/
See attached: Logcat, Screenshots
Reporter | ||
Comment 1•10 years ago
|
||
This issue DOES occur on 2.1
Flame 2.1
Environmental Variables:
Device: Flame Master
Build ID: 20140702040207
Gaia: 5725321dd1aef29077b6fc5c4c49b43dccf208dc
Gecko: 7075808c3306
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
No auto-correct or word suggestion bar appears when typing
This issue does NOT occur on 1.4 Flame.
Environmental Variables:
Device: Flame 1.4
Build ID: 20140702063007
Gaia: e8599c2b346addf3bf857310502e5b542ae7d0b2
Gecko: 5ff8eb391b65
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
Tamil was not an available language.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Reporter | ||
Updated•10 years ago
|
Summary: [B2G][Keyboard] The symbols on the Tamil Keyboard do not match what is seen on www.branah.com → [B2G][Keyboard] The characters on the Tamil Keyboard do not match what is seen on www.branah.com
Comment 2•10 years ago
|
||
"No auto-correct or word suggestion bar appears when typing"? This doesn't appear to be the correct actual result for 2.1
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage-]
Flags: needinfo?(ktucker) → needinfo?(dharris)
Comment 3•10 years ago
|
||
Delphine - Can you triage this to determine if this is a blocker for l10n?
Flags: needinfo?(lebedel.delphine)
Comment 4•10 years ago
|
||
Shipping locale. We should block on this until we get an answer from the localizer on what is the appropriate behavior for the keyboard
blocking-b2g: --- → 2.0?
Flags: needinfo?(lebedel.delphine) → needinfo?(arunprakash.pts)
Updated•10 years ago
|
Depends on: tamil-keyboard
Comment 5•10 years ago
|
||
This will be ok when bug 1022339 is resolved.
Flags: needinfo?(arunprakash.pts)
Comment 6•10 years ago
|
||
http://www.branah.com/tamilinscript is made by four levels and is very complex, so we are deciding going for other keyboard layout for tamil in the above mentioned bug 1022339.
One issue to be noted is, "when the shift key is active and the keyboard is populated with new characters, the user is unable to type any of the new characters". This is happening for hindi also. Since we are not able to type the upper case characters, i am using alt; so if you long press a character,the alternate character will be typed.
This issue needs to be addressed. I think this is happening because we are using "imEngine: 'india'"; but i am not sure.
Flags: needinfo?(dharris)
Comment 7•10 years ago
|
||
(In reply to ktucker from comment #2)
> "No auto-correct or word suggestion bar appears when typing"? This doesn't
> appear to be the correct actual result for 2.1
This is because, there is no dictionary for tamil as of now.
Comment 8•10 years ago
|
||
(In reply to Arun Prakash from comment #6)
> One issue to be noted is, "when the shift key is active and the keyboard is
> populated with new characters, the user is unable to type any of the new
> characters". This is happening for hindi also. Since we are not able to type
> the upper case characters, i am using alt; so if you long press a
> character,the alternate character will be typed.
Triage: Usability issue specific to a shipping language.
Rudy to find the dup bug.
Flags: needinfo?(rlu)
Comment 9•10 years ago
|
||
Re-adding needinfo here since it shouldn't have been cleared.
Flags: needinfo?(dharris)
Assignee | ||
Comment 11•10 years ago
|
||
Dupe bug 1031214 to this one since this has gone through triage and have more context.
Blocking based on comment 4.
blocking-b2g: 2.0? → 2.0+
Reporter | ||
Comment 13•10 years ago
|
||
Incorrect actual result for Flame 2.1 in comment 1
Actual Result for Flame 2.1: Keyboard does not match what is shown on http://www.branah.com/tamilinscript
Flags: needinfo?(dharris)
Reporter | ||
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage-] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Assignee | ||
Comment 14•10 years ago
|
||
[Root Cause]
In bug 1013570, we change the way keyboard.js send keycode to IM Engine, so that latin IMEngine could have both lowercase keycode and uppercase keycode, see that bug for why we need this.
However, for all non-latin IM engines, we should send the correct keycode based on the current capitalized state.
Blocks: 1013570
Assignee | ||
Comment 15•10 years ago
|
||
This is a band-aid fix to this issue, and also in keyboard.js without unit test protection.
However, I think it is also a minimal fix that we don't have to fix each IM engine for adopting that improper interface which need both lowercase and uppercase keycodes to be passed in.
I plan to add integration test for this, but that will need bug 1031174 to be addressed.
--
Tim, could you please help review this?
Thank you.
Attachment #8454243 -
Flags: review?(timdream)
Assignee | ||
Updated•10 years ago
|
Whiteboard: LocRun2.0 → LocRun2.0, [p=1]
Target Milestone: --- → 2.0 S6 (18july)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 16•10 years ago
|
||
Forgot to mention that this also fixed an UI issue about the [ABC] key of Tamil keyboard layout.
Comment 17•10 years ago
|
||
Comment on attachment 8454243 [details]
Patch V1
Seems to be the least evil hack for now... Please update the comment to state this is a hack to be removed.
Attachment #8454243 -
Flags: review?(timdream)
Assignee | ||
Comment 18•10 years ago
|
||
Comment on attachment 8454243 [details]
Patch V1
Comment updated.
Tim, could you please help review again?
Thanks.
Attachment #8454243 -
Flags: review?(timdream)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Updated•10 years ago
|
Attachment #8454243 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 19•10 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/8a7fb294444869ddaf869a58b21588752b9ce561
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite?
Comment 20•10 years ago
|
||
Comment 21•10 years ago
|
||
Reverted for being the likely cause of Gaia Python Integration Test perma-fail.
v2.0: https://github.com/mozilla-b2g/gaia/commit/f2509d29f7ee4d670d0dbc47f16e1794529aee3f
https://tbpl.mozilla.org/php/getParsedLog.php?id=43757692&tree=Mozilla-Aurora
Flags: needinfo?(rlu)
Assignee | ||
Comment 22•10 years ago
|
||
Uplifted to v2.0,
https://github.com/mozilla-b2g/gaia/commit/12afc5ca3076ea8cbcd5989b32d9d1a4f092eb8f
Flags: needinfo?(rlu)
Comment 23•10 years ago
|
||
Arun, does this appear good to you know?
thanks!
Flags: needinfo?(arunprakash.pts)
Comment 24•10 years ago
|
||
This is working fine and verified it just now.
Flags: needinfo?(arunprakash.pts)
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 25•10 years ago
|
||
Comment on attachment 8454243 [details]
Patch V1
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1013570.
[User impact] if declined: Cannot use Hindi input method. see bug 987496 comment 43, that has been approved for v1.4.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): should be low, landed to v2.0 for a while.
[String changes made]:n/a.
Attachment #8454243 -
Flags: approval-gaia-v1.4?
Updated•10 years ago
|
Attachment #8454243 -
Flags: approval-gaia-v1.4? → approval-gaia-v1.4+
Updated•10 years ago
|
status-b2g-v1.4:
--- → affected
Assignee | ||
Comment 26•10 years ago
|
||
Uplifted to Gaia v1.4,
4f92950e6d96326785a249e8acb704da3647616b
Assignee | ||
Comment 28•10 years ago
|
||
Backed out and relanded to v2.0 for bug 1053382,
64b0c0ae60fdeac953a7e2a3c368d124bf848477
Comment 29•10 years ago
|
||
verify with Flame KK v180 + v2.0 gaia/gecko, it's fine
Gaia 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
BuildID 20140914162307
Version 32.0
Keywords: verifyme
Comment 31•10 years ago
|
||
Tamil isn't RTL. Correcting. thanks!
No longer blocks: gaia-rtl
Whiteboard: [rtl-meta]
You need to log in
before you can comment on or make changes to this bug.
Description
•