Closed
Bug 1034328
Opened 10 years ago
Closed 10 years ago
Cards view is not exclusively visible
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1] )
Attachments
(1 file)
The underlying app windows are visible to the screen reader as well.
Assignee | ||
Comment 1•10 years ago
|
||
This patch ensures that cardviewshown will be fired only after the homescreen app is opened when the task manager is launched from within another app.
We then listen for cardviewshown/cardviewhide in order to show/hide the active app.
Attachment #8451863 -
Flags: review?(alive)
Comment 2•10 years ago
|
||
Comment on attachment 8451863 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21462
Hi, let's do this instead:
* Remove change in task manager. (keep task manager clean)
* Listen to cardview shown/ cardview close still in visibility manager
* Broadcast the showforscreenreader and hideforscreenreader message to each AppWindow in AppWindowManager. This is to reduce the effort spending on timing issue.
Yes, we could finally have the homescreenopened event handler as you proposed,
but that doesn't seem to be less complex.
* Some unit test.
Lemme know you have questions. Thank you!
Attachment #8451863 -
Flags: review?(alive)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> Comment on attachment 8451863 [details]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21462
>
> Hi, let's do this instead:
> * Remove change in task manager. (keep task manager clean)
> * Listen to cardview shown/ cardview close still in visibility manager
> * Broadcast the showforscreenreader and hideforscreenreader message to each
> AppWindow in AppWindowManager. This is to reduce the effort spending on
> timing issue.
hideforscreenreader will be followed by a setVisible(true) call that will unhide the homescreen when it should remain hidden. How do you propose fixing this?
> Yes, we could finally have the homescreenopened event handler as you
> proposed,
> but that doesn't seem to be less complex.
Where would that handler be? What would it do?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(alive)
Comment 4•10 years ago
|
||
Well, after thinking again I guess my idea would not be more easy than yours.
But please make unit test for your patch.
And what I am concern would be the late cardviewwillshown will fired after cardviewshown. It's weird.
Let's try this:
listen to homescreenopened event in visibility manager and check if TaskManager.isShown(),
if so fire a hidewindowforscreenreader to AppWindowManager to hide the homescreen(activeApp).
listen to cardviewclosed event and fire showwindowforscreenreader to AppWindowManager to show the activeApp(homescreen) again.
Does that work for you?
Flags: needinfo?(alive)
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!][Berlin 7/14-7/18] from comment #4)
> Does that work for you?
Yup, that works fine. I pushed a new patch.
Assignee | ||
Updated•10 years ago
|
Attachment #8451863 -
Flags: review?(alive)
Comment 6•10 years ago
|
||
Comment on attachment 8451863 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21462
Thank you!
Attachment #8451863 -
Flags: review?(alive) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•