Closed
Bug 1034404
Opened 10 years ago
Closed 10 years ago
Get rid of the Thebes backed gfxContexts in ThebesLayerD3D9
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Assuming no problems come up, the ThebesLayerD3D9 code will be removed after the next uplift (bug 1031089). The two Thebes backed gfxContexts there are all that stand between us and killing off Thebes backed gfxContext completely though. Since it's trivial to kill that code I'd like to do that.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8450717 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8450717 -
Attachment is obsolete: true
Attachment #8450717 -
Flags: review?(matt.woodrow)
Attachment #8450719 -
Flags: review?(matt.woodrow)
Comment 3•10 years ago
|
||
Comment on attachment 8450719 [details] [diff] [review]
patch
Review of attachment 8450719 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/thebes/gfxUtils.cpp
@@ +1025,5 @@
> + } else {
> + bounds = nsIntRect(nsIntPoint(0, 0), aSurface->GetSize());
> + }
> + cairo_rectangle(ctx, bounds.x, bounds.y, bounds.width, bounds.height);
> + cairo_fill(ctx);
This is a little iffy, CAIRO_OPERATOR_SOURCE has different semantics from clear I think. But this probably will be fine in all use-cases. Please do a reftest run without OMTC to verify this doesn't break on our WinXP buildbots.
Attachment #8450719 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•