Closed
Bug 1034911
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of dom::KeyAlgorithm
Categories
(Core :: DOM: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bjacob, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.
One of them is: dom::KeyAlgorithm
|
Assignee | |
Comment 1•10 years ago
|
||
I was able to just delete the HasDangerousPublicDestructor<dom::KeyAlgorithm> structure, and it compiled, so I'm not sure what that means. This is with a freshly updated trunk build.
|
Reporter | |
Comment 2•10 years ago
|
||
I haven't yet landed the new static assertions in bug 1028588 that catch this. I hope to land them later today.
|
|
Reporter | |
Comment 3•10 years ago
|
||
Also, note that these static_assertions only do anything on Clang and GCC>=4.8.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → continuation
|
|
Reporter | |
Comment 4•10 years ago
|
||
That's landed on inbound now.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8452485 -
Flags: review?(bugs)
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8452485 [details] [diff] [review]
Make the destructor for KeyAlgorithm private.
Huh.
Attachment #8452485 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
||
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•