Closed Bug 1034912 Opened 10 years ago Closed 10 years ago

Remove dangerous public destructor of DeviceStorageFile

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: bjacob, Assigned: mccr8)

References

Details

Attachments

(2 files)

Remove dangerous public destructor of DeviceStorageFile.
(deleted), patch
dhylands
: review+
Details | Diff | Splinter Review
Extra patches for B2G specific code.
(deleted), patch
mccr8
: review+
Details | Diff | Splinter Review
In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist. One of them is: DeviceStorageFile
Assignee: nobody → continuation
Comment on attachment 8464352 [details] [diff] [review] Remove dangerous public destructor of DeviceStorageFile. Review of attachment 8464352 [details] [diff] [review]: ----------------------------------------------------------------- Excellent. Looks good to me.
Attachment #8464352 - Flags: review?(dhylands) → review+
Backed out, because apparently B2G uses this some place. I'll figure that out at some point. https://hg.mozilla.org/integration/mozilla-inbound/rev/8d5534ee05e9
I tried your patch on my emulator build, and it failed to build. I added these changes and then it built locally.
Comment on attachment 8465079 [details] [diff] [review] Extra patches for B2G specific code. Review of attachment 8465079 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, I'll land this as part 1.
Attachment #8465079 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d493246f3801 https://hg.mozilla.org/mozilla-central/rev/9bf776569074
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: