Closed
Bug 1034916
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of nsUTF8ConverterService
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bjacob, Assigned: mccr8)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist. One of them is: nsUTF8ConverterService
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 1•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40
Attachment #8464349 -
Flags: review?(ehsan)
Updated•10 years ago
|
Attachment #8464349 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1fb4230b8b8
Comment 3•10 years ago
|
||
Backed out for non-unified bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/f887288d0468 https://tbpl.mozilla.org/php/getParsedLog.php?id=44919068&tree=Mozilla-Inbound
Assignee | ||
Comment 4•10 years ago
|
||
I added an include to nsCookie.cpp and verified it builds in non-unified builds locally. https://hg.mozilla.org/integration/mozilla-inbound/rev/e48378aaf726
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e48378aaf726
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•