Closed
Bug 1034919
Opened 10 years ago
Closed 10 years ago
Remove dangerous public destructor of nsTXTToHTMLConv
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bjacob, Assigned: sworkman)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist. One of them is: nsTXTToHTMLConv
|
Assignee | |
Comment 1•10 years ago
|
||
Did a bit of rejiggering to use NS_GENERIC_FACTORY_CONSTRUCTOR_INIT and removed now-redundant factory functions. Just pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2379ec87d1ae
|
||
Updated•10 years ago
|
Attachment #8452118 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks Pat! https://hg.mozilla.org/integration/mozilla-inbound/rev/20479ebf9be8
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20479ebf9be8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•