Closed
Bug 1035062
Opened 10 years ago
Closed 10 years ago
Implement TargetHandler and TargetHandlersManager
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S1 (1aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [p=8])
Attachments
(1 file)
After bug 1029356, it's obvious that each of the key/target goes through it's own life cycle and handling. Instead of keeping a giant switch .. case, we should implement the following
-- A |DefaultTargetHandler| as the default handler of targets
-- Special handlers for special keys like backspace which inherits from DefaultTargetHandler
-- A |TargetHandlersManager| which listens to call from |ActiveTargetsManager|, and create/dispatch call to the handlers. It would need to keep a Map or WeakMap to host a mapping between targets (which is DOMElement) and the handler instances.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Whiteboard: [p=5]
Target Milestone: --- → 2.0 S6 (18july)
|
|
Assignee | |
Comment 1•10 years ago
|
||
I can no longer get this in for this sprint because of bug 1038131 and bug 1036577.
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8458391 [details]
mozilla-b2g:master PR#21898
This misses some unit tests but I think we can start the review process.
Attachment #8458391 -
Flags: review?(rlu)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8458391 [details]
mozilla-b2g:master PR#21898
Looks good to me.
Thanks.
Attachment #8458391 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8458391 [details]
mozilla-b2g:master PR#21898
Please review the test too?
Attachment #8458391 -
Flags: review+ → review?(rlu)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8458391 [details]
mozilla-b2g:master PR#21898
r+ for the tests as well, please help take a look at the comments on the GH.
Thanks.
Attachment #8458391 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [p=5] → [p=8]
You need to log in
before you can comment on or make changes to this bug.
Description
•