Closed
Bug 1035277
Opened 10 years ago
Closed 10 years ago
Make the restart of B2G before make test-perf tests optional with a command line flag or environment
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: Eli, Assigned: hub)
References
Details
(Keywords: perf, Whiteboard: [c=automation p=1 s= u=])
Attachments
(1 file)
Currently B2G is forcibly restarted before each application's set of tests with make test-perf. We need to implement a command line preference for disabling the restart of B2G between these tests.
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [c=automation p= s= u=] → [c=automation p=1 s= u=]
|
|
Assignee | |
Comment 1•10 years ago
|
||
I was more thinking of an environment variable, but that's just an implementation detail. It is needed to be able to work on bug 1027649
|
|
Assignee | |
Comment 2•10 years ago
|
||
We should the priority for this: it is important to be able to disable it at runtime so that we can find other problems like mentioned in comment 1.
Priority: P3 → P2
|
|
Assignee | |
Comment 3•10 years ago
|
||
The PR includes the patch for bug 1027232 because it depends on it. This is only for this part.
Attachment #8461585 -
Flags: review?(gaye)
|
|
Assignee | |
Updated•10 years ago
|
Summary: Make the restart of B2G before make test-perf tests optional with a command line flag → Make the restart of B2G before make test-perf tests optional with a command line flag or environment
|
|
Assignee | |
Comment 4•10 years ago
|
||
RESTART_B2G=0 make test-perf to disable.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Feedback addressed.
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8461585 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/marionette-device-host/pull/3
LGTM with a few last nits on GH. Nice work!
Attachment #8461585 -
Flags: review?(gaye) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Commented or addressed the nits.
Thank you kindly.
Merged
https://github.com/mozilla-b2g/marionette-device-host/commit/2434343e651a30b67ef69c95197e59b5cd7c0dfd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•