vasanth Assignee
	Description • 10 years ago

STR:
----
1. Open the Music App.
2. Play an AAC/MP3 clip with length more than 60secs. (only in offload playback)
3. Pause the playback.
4. Perform seek.
5. The progress bar pointer moves to beginning of the progress bar.
6. Resume the playback. But the audio resumes from the the seeked position in Step4.

Analysis
--------
It's a bug in my code [1] uncovered by fix for [2]

Always MediaOmxDecoder::PlaybackPositionChanged() should be called during offload playback,
but since I didn't make it virtual, MediaDecoder::PlaybackPositionChanged() 
was called when seek completed [3], which resets seek bar in UI.

Also made sure all other functions overridden in child (MediaOmxDecoder) are declared virtual in parent (MediaDecoder)

Attached the fix. 

[1] https://bugzil.la/976172
[2] https://bugzil.la/778077
[3] http://dxr.mozilla.org/mozilla-central/source/content/media/MediaDecoder.cpp#1077

	vasanth Assignee
	Comment 1 • 10 years ago

Hi Robert, 
Could you please give try run if needed? 
Else can we add checkin-needed?

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 2 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=aa768f76f791

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 3 • 10 years ago

You should get level 1 access so you can tryserver things yourself :-)

	vasanth Assignee
	Comment 4 • 10 years ago

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> You should get level 1 access so you can tryserver things yourself :-)

Yep. Trying for that.
Starred 2 failures in try build. Adding checkin-needed flag

	Carsten Book [:Tomcat]
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8412692a3b5

	Carsten Book [:Tomcat]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/a8412692a3b5

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/9297a56e155e

	Robert Mead [:RobertM]
	Comment 8 • 10 years ago

covered by this test case because it covers slider bar(scrubber) manipulation:
https://moztrap.mozilla.org/manage/case/8519/

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 9 • 10 years ago

Test case has been added to moztrap:

https://moztrap.mozilla.org/manage/case/14324/