Closed
Bug 1035775
Opened 10 years ago
Closed 10 years ago
[B2G][System] support 24 hour time format
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(feature-b2g:2.1)
People
(Reporter: howie, Assigned: gasolin)
References
Details
(Whiteboard: [systemsfe][p=2])
Attachments
(1 file)
There will be a setting toggle to let user choose between 12/24 hour time format in v2.1. User story and settings spec: Bug 903683
For system app, the tasks to do after toggle is added would be:
1.Read/listen to the time format toggle value/change event.
2.Input the corresponding time format to existing mozL10n.DateTimeFormat() function. Currently the input time format should be a fixed 12 hour
shortTimeFormat = %I:%M %p , line 201 of http://goo.gl/DR4CNe. There will be a 24 hour time format added.
3.Show the return of the function as it's doing now.
Updated•10 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 1•10 years ago
|
||
WIP, to demonstrate navigator.mozHour12 API shim usage.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [systemsfe] → [systemsfe][p=2]
Target Milestone: --- → 2.1 S3 (29aug)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gasolin
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8471310 [details]
pull request redirect to github
the patch did not cover lockscreen and time picker.
Attachment #8471310 -
Flags: review?(alive)
Comment 3•10 years ago
|
||
I think there's more to fix in System
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L910
But most important
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js#L482
Which determines how to display the time picker.
Comment 4•10 years ago
|
||
Comment on attachment 8471310 [details]
pull request redirect to github
What's the followup plan for lockscreen and timepicker?
Attachment #8471310 -
Flags: review?(alive) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Greg is proposing lockscreen patch in bug 1035754 now.
For time picker it seems needs separate work and through test.
So I'd fire a separate bug 1054135 as a followup for systemfe.
Assignee | ||
Comment 6•10 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/0cc4f10ffd9deb10056b4096021458fc1e34a9ee
thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2.1 S3 (29aug) → 2.1 S2 (15aug)
After opening multiple apps and switching between 12hr, and 24hr Time Format it seems that the phone is correctly updating the system Time. However, I am unable to verify this bug due to its depends on not being verified yet (bug 1023735)
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•