/home/icecold/mozilla-central/xpcom/base/VisualEventTracer.cpp:646:1: error: static_assert failed "Reference-counted class VisualEventTracer should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it." NS_IMPL_ISUPPORTS(VisualEventTracer, nsIVisualEventTracer)

Comment on attachment 8452623 [details] [diff] [review] event_tracer_destructor.patch Review of attachment 8452623 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the changes below. ::: xpcom/base/VisualEventTracer.cpp @@ +551,1 @@ > virtual ~VisualEventTracerLog(); Please make this non-virtual and the class MOZ_FINAL while you are here. ::: xpcom/base/VisualEventTracer.h @@ +218,5 @@ > { > NS_DECL_ISUPPORTS > NS_DECL_NSIVISUALEVENTTRACER > +private: > + virtual ~VisualEventTracer() {} Please don't make this virtual and mark the class as MOZ_FINAL.