Closed Bug 1036177 Opened 10 years ago Closed 6 years ago

Consider using unicode stars instead of graphical stars for ratings

Categories

(Marketplace Graveyard :: Consumer Pages, enhancement, P5)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: cvan, Assigned: pisani.erica)

Details

(Keywords: perf, Whiteboard: [good first bug])

You can make stars with plain text! So let's ditch our graphics and do that. ★★★☆★★☆Check it out★★★☆☆★☆☆★ http://jsbin.com/qesuwube/3/ ★★★☆☆★★★☆☆★★★☆☆★★★☆☆★★★☆☆★★☆
Agreed. I thought I filed a bug for this when we were doing tarako, but I must have forgotten.
Keywords: perf
MAJORLY into this. :D Blue star: #4cb1ff Grey star: #cbcbcb
Priority: -- → P5
Whiteboard: [contribute]
Summary: Consider using unicode stars instead of graphical stars → Consider using unicode stars instead of graphical stars for ratings
Whiteboard: [contribute] → [good first bug]
Can I work on this ?
Sure. Thanks for volunteering! :)
Wil, Can you please put my name in assignee list ?
Assignee: nobody → vaishnav.rd
Hi, Please guide me how to get started with this and what is the scope of this bug. Thanks !
Kevin, could you lend a hand, please? Thanks
Flags: needinfo?(kngo)
Ram found chuck on IRC
Flags: needinfo?(kngo)
I am working on this.
Un-assigning myself if someone else want to work on this. Hi Chuck/David, Could you please comment here some guidance to help newbies in fixing this? Thanks, Ram
Assignee: vaishnav.rd → nobody
Flags: needinfo?(ddurst)
Flags: needinfo?(ddurst) → needinfo?(charmston)
We'd want to use the U+2605 character instead of the SVG solution we currently use. In comment 2, Phil provided colors, and the links cvan provided in comment 3 show a few excellent techniques for doing so (though I don't think we'd want to have the overhead of a polymer component, those do showcase approaches one might take).
Flags: needinfo?(charmston)
I want to work on this.!
Sure Dipankar, assigning you here. For any help, feel free to refer to marketplace documentation at http://marketplace.readthedocs.org/ or use #marketplace irc.
Assignee: nobody → dipankar.sonwane
Status: NEW → ASSIGNED
Hey Dipankar, are you still working on this? Are you stuck? Do you need help?
Flags: needinfo?(dipankar.sonwane)
Mentor: charmston
Assignee: dipankar.sonwane → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(dipankar.sonwane)
Assigning to Erica, if you're interested!
Assignee: nobody → pisani.erica
https://github.com/mozilla/fireplace/commit/6cbb485db95858f0f0d6735ae9252eb91289c4f1 Thanks, Erica! Marking as resolved to make sure QA gets a look at it.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thanks Erica! I've also added your contribution here: https://wiki.mozilla.org/Marketplace/Contributing/Sep2015#Contributor_Recognition
This was reverted in https://github.com/mozilla/fireplace/commit/7ac5763eee0c4a118d6fc962abb29427df6b213b because of some issues in some pages on Win/Mac/Linux. See https://github.com/mozilla/fireplace/pull/1483 for the details. We still want this, but we need to address those issues.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Erica Pisani from comment #17) > PR is up: https://github.com/mozilla/fireplace/pull/1482 We'd still love to have this. Any chance you could address the issues in #c20?
Flags: needinfo?(pisani.erica)
Hey David, Sorry for the delay in getting this resolved, things have been a bit crazy on my end (currently in the middle of a school semester) so I haven't had time to address the issues that caused this to be reopened. I'll see if I can take care of the things in #c20 this weekend :)
Flags: needinfo?(pisani.erica)
Here's the new PR: https://github.com/mozilla/fireplace/pull/1539 This has the fix for the write-a-review modal star selection, but as I've noted on the PR, I'm unable to test to see if my changes have resolved the Windows star sizing issue. Let me know if there's anything that I can do to get around that (short of buying a Windows computer).
Really close. The issue is still there with Windows (everything else seems fine, and looks great), in FF and Edge, so it's related to the system font sizing. If you use VirtualBox, you should be able to check this out without buying a Windows computer (let's not get crazy) -- runs Windows pretty quickly too.
Mentor: charmston
No longer blocks: marketplace-perf
Firefox Marketplace has been shut down since March. Closing remaining bugs.
Status: REOPENED → RESOLVED
Closed: 9 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.