Closed
Bug 1036280
Opened 10 years ago
Closed 10 years ago
Newly added links are type=undefined instead of history
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
(deleted),
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
Links from PlacesProvider get type=history except when they're created from onLinkChanged.
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Iteration: 33.3 → ---
Comment 2•10 years ago
|
||
Comment on attachment 8452898 [details] [diff] [review]
v1
Review of attachment 8452898 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8452898 -
Flags: review?(adw) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Updated•10 years ago
|
Iteration: --- → 33.3
QA Whiteboard: [qa?]
Comment 5•10 years ago
|
||
Please provide STR's for QA verification. Thank you.
QA Whiteboard: [qa?] → [qa+]
Assignee | ||
Comment 6•10 years ago
|
||
There's a unit test that covers this already. There's no real visual indication of a site being type=undefined vs type=history right now, but you could see this missing:
1) clear history so tiles are empty
2) type in a url to visit in the location bar
3) open a new tab and see the just visited page
4) pin the page
5) check about:config browser.newtabpage.pinned to see if there's a type value in the json
Updated•10 years ago
|
QA Contact: cornel.ionce
Comment 7•10 years ago
|
||
Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.2 using latest Nightly 33.0a1 (buildID: 20140716030202) and the following mentions should be done:
- if I have three pinned pages, I have the following value in browser.newtabpage.pinned (from about:config): [{"url":"http://www.wikipedia.org/","frecency":2000,"lastVisitDate":1405603943983000,"type":"history","title":"Wikipedia"},{"url":"https://moztrap.mozilla.org/results/runs/","frecency":2000,"lastVisitDate":1405604013241000,"type":"history","title":"MozTrap | Results-Runs"},{"url":"https://quality.mozilla.org/","frecency":2000,"lastVisitDate":1405604036947000,"type":"history","title":"QMO – quality.mozilla.org | The Home of Mozilla QA"}]
- if I unpin the second pinned page, I have the following value in browser.newtabpage.pinned (from about:config): [{"url":"http://www.wikipedia.org/","frecency":2000,"lastVisitDate":1405603753063000,"type":"history","title":"Wikipedia"},null,{"url":"https://quality.mozilla.org/","frecency":100,"lastVisitDate":1405603771911000,"type":"history","title":"QMO – quality.mozilla.org | The Home of Mozilla QA"}]
- if I unpin all those three pages, I have the following value in browser.newtabpage.pinned (from about:config): []
It is ok? Is this behaviour intended?
Flags: needinfo?(edilee)
QA Contact: cornel.ionce → camelia.badau
Comment 8•10 years ago
|
||
(In reply to Camelia Badau, QA [:cbadau] from comment #7)
> It is ok? Is this behaviour intended?
Yes.
Flags: needinfo?(edilee)
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•