Closed Bug 1036336 Opened 10 years ago Closed 10 years ago

[Collection App] Icons jump after rendering all of them

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 verified)

RESOLVED FIXED
2.0 S6 (18july)
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- verified

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

Attached video Video (deleted) —
STR: 1) Open "Social" smart collection (or whatever) 2) See how the content is translated some pixels when all icons are rendered and the scroll detects it Video attached to show the issue ----- https://github.com/mozilla-b2g/gaia/blob/master/apps/collection/view.html#L79 Notice that <gaia-grid> has not height because all the content is translated with transformations. The issue disappears if I add this here https://github.com/mozilla-b2g/gaia/blob/master/apps/collection/style/css/view.css#L1 height: 1000%;
Vivien, should I move this to Zoom&Pan component? or any suggestion is more than welcome
Flags: needinfo?(21)
Whiteboard: [systemsfe]
(In reply to Cristian Rodriguez (:crdlc) from comment #1) > Vivien, should I move this to Zoom&Pan component? or any suggestion is more > than welcome Just removing flex-direction: column on the container also seems to resolve the issue for this case. But it breaks the offline case. Seems much more a css issue related to the usage of flex than a pan/zoom issue to me.
Flags: needinfo?(21)
Blocks: vertical-home-next
No longer blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request (deleted) —
Attachment #8453636 - Flags: review?(kgrandon)
Thanks Vivien, good catch (In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #2) > (In reply to Cristian Rodriguez (:crdlc) from comment #1) > > Vivien, should I move this to Zoom&Pan component? or any suggestion is more > > than welcome > > Just removing flex-direction: column on the container also seems to resolve > the issue for this case. But it breaks the offline case. > > Seems much more a css issue related to the usage of flex than a pan/zoom > issue to me.
Comment on attachment 8453636 [details] Github pull request Things seem to keep working for me, and I'm not seeing a "jump", so looks good to me. Thanks!
Attachment #8453636 - Flags: review?(kgrandon) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Attached video video (deleted) —
This issue has been verified successfully on Flame 2.1 See attachment: Verify_1036336.MP4 Reproducing rate: 0/5 Flame 2.1 build: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141202001201 Version 34.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: