Hi guys! I think I found a weird issue regarding /system/test/unit/app_install_manager_test.js Oddly the result of running this suite of tests is: 28 passing (600ms) The problem is that some errors are shown in the console: JavaScript error: app://system.gaiamobile.org/test/unit/app_install_manager_test.js?time=1404908206512, line 666: this.sinon is undefined JavaScript error: app://system.gaiamobile.org/js/app_install_manager.js?time=1404908206692, line 16: SystemBanner is not a constructor These errors seem to be causing some tests not to be run (in fact, if they would be run, they would fail :O). More concretely, no tests are run from this suite on -> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/app_install_manager_test.js#L665 :O In fact, the first sinon related error takes places in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/app_install_manager_test.js#L666 Thanks!

Hi Greg, I think this could be related to your patch for bug 1027471 so maybe you would like to give it a look ;) Thanks!

Hi guys! I just git reverted https://github.com/snowmantw/gaia/commit/61ab5bf41df531eaee8dcbf2511ddd5608e2e9d7 and the issue is solved. Without bug 1027471 's patch I get all the tests passing (195 passing (6s)) and no errors on the console.

Closing this bug since already reverted the patch for bug 1027471 ;)

I've opened bug 1036955 to track the fact that our unit tests should have been red.