Closed Bug 1036409 Opened 10 years ago Closed 10 years ago

[e10s] Inspector doesn't re-select the last selected node after page reload

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(e10s+)

VERIFIED FIXED
Firefox 36
Tracking Status
e10s + ---

People

(Reporter: pbro, Assigned: harth)

References

Details

Attachments

(1 file)

In a non e10s tab: - Open the inspector - Select a node nested somewhere (not just html, head or body, something nested below that) - Reload the page ==> Observer that the markup-view auto-expands to that node and selects it In an e10s tab: ==> body is always reselected by default
Blocks: dte10s
This is controlled by selectionCssSelector and is most likely failing because of the call to _target.url in the getter http://dxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/inspector-panel.js#381
Also, the call a get the CSS selector is not remote safe for the same reason that the "Copy Unique Selector" context menu isn't. See https://bugzilla.mozilla.org/show_bug.cgi?id=967201#c4 for an explanation of how to fix this part
Depends on: 967201
Assignee: nobody → fayearthur
Well, that was easy after all. Uses the new remote getUniqueSelector() method. Try: https://tbpl.mozilla.org/?tree=Try&rev=bad28252a0bc
Attachment #8508932 - Flags: review?(pbrosset)
Comment on attachment 8508932 [details] [diff] [review] Use remote method to get unique selector Review of attachment 8508932 [details] [diff] [review]: ----------------------------------------------------------------- R+ assuming a green try build.
Attachment #8508932 - Flags: review?(pbrosset) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Blocks: 1074836
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Reproduced the initial issue in Firefox 36 Nightly from 2014-10-21. The issue no longer reproduces in the latest Firefox 38 Nightly (BuildID=20150211222327) on Windows 7 x64, Mac OS X 10.9.5, Ubuntu 12.04 x86.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: