Closed Bug 1036553 Opened 10 years ago Closed 10 years ago

Fix cropped software home button

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S6 (18july)
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: afarden, Assigned: afarden)

References

Details

Attachments

(2 files)

B2GFix.JPG
(deleted), image/jpeg
Details
the scaling of the home button asset is larger than the actual button (4rem vs 3.6rem)
(deleted), text/x-github-pull-request
alive
: review+
Details
Attached image B2GFix.JPG (deleted) —
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 Steps to reproduce: The software home button is cropped due to bad scaling.
the above pull request is for v2.0, this one is for master https://github.com/mozilla-b2g/gaia/pull/21550
Nice, hacking the Xperia SP drives some fixes :)
(In reply to Adam Farden from comment #4) > Created attachment 8453632 [details] > the scaling of the home button asset is larger than the actual button (4rem > vs 3.6rem) Thanks for this PR, but please do it against master and not 2.0 :)
The attached link is for master, as is the second link in the comments!
Comment on attachment 8453632 [details] the scaling of the home button asset is larger than the actual button (4rem vs 3.6rem) Nice!
Attachment #8453632 - Flags: review?(alive) → review+
I've seen this on the Nexus 5 too.
Assignee: nobody → adam
Blocks: 1038262
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/2cba8b970378bdbc049af23c3b2bced1702006e1
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
I picked up tip gaia last night and this is indeed fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: