Closed Bug 103676 Opened 23 years ago Closed 23 years ago

Biff leaks passwords

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

(Keywords: memory-leak)

Attachments

(1 file, 1 obsolete file)

I believe this happens every time biff fires, every time if you've got remember password turned on, and every time after you log on, if you don't have remember password turned on. Fix coming up: Here's the stack trace: malloc [msvcrt.DLL] nsMemoryImpl::Alloc(UINT) [nsMemoryImpl.cpp:320] nsMemory::Alloc(UINT) [nsMemoryImpl.cpp:556] nsMsgIncomingServer::GetPassword(char * *) [nsMsgIncomingServer.cpp:675] { NS_ENSURE_ARG_POINTER(aPassword); => *aPassword = ToNewCString(m_password); return NS_OK; } nsTimer::Fire(void) [nsTimer.cpp:209] // invoke notification routine if (mFunc != nsnull) { => (*mFunc)(this, mClosure); } else if (mCallback != nsnull) { mCallback->Notify(this); nsTimerManager::FireNextReadyTimer(UINT) [nsTimerManager.cpp:130] nsAppShell::Run(void) [nsAppShell.cpp:131]
Status: NEW → ASSIGNED
Keywords: mlk
Attached patch proposed fix (obsolete) (deleted) — Splinter Review
Attached patch -uw patch (deleted) — Splinter Review
Comment on attachment 52538 [details] [diff] [review] -uw patch sr=sspitzer
Attachment #52538 - Flags: superreview+
Comment on attachment 52538 [details] [diff] [review] -uw patch r=hwaara
Attachment #52538 - Flags: review+
r=naving
QA Contact: esther → stephend
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified FIXED using the latest CVS pull and Purify, with my scenario - * Launching mozilla.exe -mail with 1 POP3 server, with 2 new messages. * Login at startup and saved password selected. * Didn't actually read mail, just let biff notify me of new messages * Then, I did a new Get Msg, but chose to save the password this time.
Status: RESOLVED → VERIFIED
*** Bug 99141 has been marked as a duplicate of this bug. ***
*** Bug 33155 has been marked as a duplicate of this bug. ***
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: