Closed
Bug 1036877
Opened 10 years ago
Closed 10 years ago
Failed to build B2G desktop with MOZ_B2G_RIL enabled, "Reference-counted class IccManager should not have a public destructor"
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
|
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1035394 +++
This is a follow-up of bug 1028588, which added such detection to much of nsISupportsImpl.h but left out _INHERITED macros.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch either adds a private dummy dtor to RIL ref-counted components or move their public dtor to private section.
Attachment #8453737 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
OS: Gonk (Firefox OS) → Mac OS X
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=1]
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8453737 [details] [diff] [review]
bug-1035394.patch
Review of attachment 8453737 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you.
Attachment #8453737 -
Flags: review?(htsai) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Any particular reason why an extra private has been inserted in numerous files e.g. http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/IccListener.h
|
|
Assignee | |
Comment 7•10 years ago
|
||
(In reply to Ian Neal from comment #6)
> Any particular reason why an extra private has been inserted in numerous
> files e.g.
> http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/
> IccListener.h
When compiled on Mac or any other platform with MOZ_IS_DESTRUCTIBLE turned on, it fails to when some ref-counted class has explicit or implicit dtor.
You need to log in
before you can comment on or make changes to this bug.
Description
•