Open Bug 1037103 Opened 10 years ago Updated 2 years ago

Remove Scoped.h

Categories

(Core :: MFBT, defect, P3)

Product:
Core
Component:
MFBT
Type:
defect

Tracking

()

Status:
REOPENED

People

(Reporter: Waldo, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: leave-open)

Attachments

(2 files)

Remove ScopedDeleteArray from Scoped.h
(deleted), patch
jcranmer
: review+
Details | Diff | Splinter Review
Add deprecation notice/comments to Scoped.h
(deleted), patch
jcranmer
: review+
Details | Diff | Splinter Review
Once people have switched to UniquePtr.h, we should remove this file.
Patch awaits review of the current patches in bug 1037100, of course. But no harm posting in advance of that.
Attachment #8454259 - Flags: review?(Pidgeot18)
Assignee: nobody → jwalden+bmo
Status: NEW → ASSIGNED
In advance of complete removal, at least we can clearly mark it as deprecated in the comments.
Attachment #8454260 - Flags: review?(Pidgeot18)
Attachment #8454259 - Flags: review?(Pidgeot18) → review+
Attachment #8454260 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/mozilla-central/rev/4f8848a15d76
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
ScopedDeleteArray is removed (with a comment pointing searches to UniquePtr<T[]>). https://hg.mozilla.org/integration/mozilla-inbound/rev/e2044e4fd875
Keywords: leave-open
Target Milestone: mozilla34 → ---
Depends on: 1260642
The leave-open keyword is there and there is no activity for 6 months. :Waldo, maybe it's time to close this bug?
Flags: needinfo?(jwalden+bmo)
No, this is still valid. Just not a huge priority.
Flags: needinfo?(jwalden+bmo)

The leave-open keyword is there and there is no activity for 6 months.
:froydnj, maybe it's time to close this bug?

Flags: needinfo?(nfroyd)

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #8)

The leave-open keyword is there and there is no activity for 6 months.
:froydnj, maybe it's time to close this bug?

Comment 7 says it all.

Flags: needinfo?(nfroyd)

The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?

Flags: needinfo?(jwalden)

The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?

Flags: needinfo?(jwalden)

The leave-open keyword is there and there is no activity for 6 months.
:sg, maybe it's time to close this bug?

Flags: needinfo?(sgiesecke)

The bug still makes sense.

The following uses of symbols from Scoped.h are remaining right now:

  • 2 uses of SCOPED_TEMPLATE
  • 6 uses of MOZ_TYPE_SPECIFIC_SCOPED_POINTER_TEMPLATE
  • 20 uses of Scoped, but some of those being typedefs with further uses
Flags: needinfo?(sgiesecke)
Flags: needinfo?(jwalden)

The leave-open keyword is there and there is no activity for 6 months.
:glandium, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mh+mozilla)

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: jwalden → nobody
Severity: normal → S3

gcp, do you think we should finish this ?

Flags: needinfo?(mh+mozilla) → needinfo?(gpascutto)

Yeah, why not, just not a huge priority. "Good third bug".

Severity: S3 → S4
Flags: needinfo?(gpascutto)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: