Closed
Bug 1037164
Opened 10 years ago
Closed 10 years ago
Preferences::SetFloat has a declaration but no definition
Categories
(Core :: Preferences: Backend, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Preferences::SetFloat was added to Preferences.h in bug 826586 but it doesn't appear to ever have had an actual implementation.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8454031 -
Flags: review?(bzbarsky)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8454031 [details] [diff] [review]
Patch
r=me
Attachment #8454031 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
There are no issues with one thread setting, one thread accessing and the one getting the value managing to get half old half new value?
|
|
Assignee | |
Comment 5•10 years ago
|
||
The float is stored as a string because we don't have native float preferences. So there should be no problem here, assuming that string prefs work.
|
|
||
Comment 6•10 years ago
|
||
> There are no issues with one thread setting, one thread accessing
Preferences are main-thread-only.
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•