Closed
Bug 1037291
Opened 10 years ago
Closed 10 years ago
Make BluetoothDiscoveryHandle expire when discovery is stopped
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
(Whiteboard: [webbt-api])
Attachments
(1 file, 1 obsolete file)
When adapter A gets a discovery handle from |startDiscovery|, prior discovery handles held by either adapter A or other adapters should expire and stop listening to "DeviceFound" bluetooth signal.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → btian
Whiteboard: [webbt-api]
Assignee | ||
Comment 1•10 years ago
|
||
Also reject promise of startDiscovery when discovery is already started, in order to inform applications to get a new discovery handle from another startDiscovery call.
Attachment #8454231 -
Flags: review?(echou)
Updated•10 years ago
|
Blocks: webbt-test-device
Updated•10 years ago
|
Blocks: webbt-test-discovery
Comment 2•10 years ago
|
||
Comment on attachment 8454231 [details] [diff] [review]
Patch 1 (v1): Make BluetoothDiscoveryHandle expire when discovery is stopped
Review of attachment 8454231 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nit addressed.
::: dom/bluetooth2/BluetoothAdapter.cpp
@@ +400,5 @@
> }
>
> +void
> +BluetoothAdapter::SetDiscoveryHandleInUse(
> + nsRefPtr<BluetoothDiscoveryHandle> aDiscoveryHandle)
nit: please do not pass a nsRefPtr as an argument since it's wasteful.
https://developer.mozilla.org/en-US/docs/Using_nsCOMPtr/Getting_Started_Guide#nsCOMPtrs_in_function_signatures
Attachment #8454231 -
Flags: review?(echou) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Revise based on reviewer's comment.
Attachment #8454231 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•