Closed
Bug 1037406
Opened 10 years ago
Closed 10 years ago
FxA login does not fail correctly when connection times out
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.0 affected)
RESOLVED
DUPLICATE
of bug 998464
tracking-b2g | backlog |
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | affected |
People
(Reporter: mgoodwin, Assigned: jhirsch)
Details
(Whiteboard: [2.0-flame-test-run-2] [2.0-flame-test-run-3])
STR:
1) Go to sign into FxA, e.g. via Find My Device
2) click "Create account or sign in"
3) interrupt network conenctivity (e.g. pull the cable from your wireless router, change some iptables rules, etc.)
4) enter email address and click 'next'
Expected behaviour:
FxA should fail with an error
Actual behaviour:
Flow falls through to signup (it shows the prompt for Age Verification)
Comment 1•10 years ago
|
||
Is the problem that it does not fail soon enough, or that it does not fail with a clean error screen?
Updated•10 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Sam Penrose from comment #1)
> Is the problem that it does not fail soon enough, or that it does not fail
> with a clean error screen?
There are 2 problems, I think:
1) When FxA can't talk to the server, the correct UX is to give some kind of error, not fall through to some (possibly incorrect path); if you're intending to log in, prompting for signup questions is not the right thing to do.
2) When other things are making use of FxA (e.g. Find My Device), you'd expect them to be able to handle errors; as things stand, the only way to hit the error handler is to close the FxA login.
Comment 3•10 years ago
|
||
2) is a bug: FxA should report the error to the user. I personally don't see reporting the error one screen too late as material, but that's up to product.
Jared is out for a chunk of next week; LMK if I should try to field this one.
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Sam Penrose from comment #3)
> 2) is a bug: FxA should report the error to the user. I personally don't see
> reporting the error one screen too late as material, but that's up to
> product.
It's not just one screen too late; it might be the wrong screen.
E.g. if I already have an account, failure leads me to fall out of sign-in flow into 'create account' flow.
Comment 5•10 years ago
|
||
You're quite right; my mistake.
Comment 6•10 years ago
|
||
My guess is we will want to uplift a fix for this; please let us know.
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
blocking-b2g: 2.0? → 2.0+
Assignee | ||
Comment 7•10 years ago
|
||
This looks an awful lot like bug 1026603, which was closed as a dupe of bug 998464 and declared a non-blocker.
Can we reconsider the nomination here?
Flags: needinfo?(bbajaj)
Comment 8•10 years ago
|
||
Bhavana, as Jared says above, Bug 998464 was - ed for blocking 2.0 because this involves sudden loss of inernet connection, which was considered pretty remote. I think since this is quite similar to 998464, we could consider it as a non-blocker. What's your take on this?
Updated•10 years ago
|
Assignee: nobody → salva
Assignee | ||
Comment 9•10 years ago
|
||
Hi :salva, I'm going to take this bug if you don't mind. I've been working on FxA for a while now.
Assignee: salva → 6a68
Comment 10•10 years ago
|
||
This is obviously not ideal, but I would not block due to the very specific network-drop timings required to reproduce. It also seems that the user does not get locked into the flow in the failure case (though they may be confused)
I'd like to see this a high priority fix for 2.1
Comment 11•10 years ago
|
||
(In reply to Adam Rogers (:arog) from comment #10)
> This is obviously not ideal, but I would not block due to the very specific
> network-drop timings required to reproduce. It also seems that the user does
> not get locked into the flow in the failure case (though they may be
> confused)
>
> I'd like to see this a high priority fix for 2.1
Thanks, moving it to backlog so we don't lose it.
blocking-b2g: 2.0+ → backlog
Flags: needinfo?(bbajaj)
Comment 12•10 years ago
|
||
(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #9)
> Hi :salva, I'm going to take this bug if you don't mind. I've been working
> on FxA for a while now.
No problem.
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
Whiteboard: [2.0-flame-test-run-2] [2.0-flame-test-run-3]
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•