Closed
Bug 1037755
Opened 10 years ago
Closed 10 years ago
RTL - Fix Forward and Backward arrow positions
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Firefox OS Graveyard
Gaia::First Time Experience
All
Gonk (Firefox OS)
Tracking
(b2g-v2.2 verified)
VERIFIED
FIXED
2.2 S2 (19dec)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | verified |
People
(Reporter: nefzaoui, Assigned: sfoster)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
Since RTL direction is from Right to Left, Go Forward button should be on the left, Backward to the right, and that's how it is right now, however arrows positions are not correct.
Comment 1•10 years ago
|
||
Hi Ahmed! Can you clarify which arrows? Some of the ones I see in recent builds appear to be correct, so I want to make sure we find and assign these correctly. Thank you!
Flags: needinfo?(nefzaoui.ahmed)
Reporter | ||
Comment 3•10 years ago
|
||
Mystery solved! We can't move on further until blocker is resolved.
Depends on: 1082541
Flags: needinfo?(nefzaoui.ahmed)
Updated•10 years ago
|
Assignee | ||
Comment 5•10 years ago
|
||
Are we sure that we need to reverse the direction of these buttons? I understood that we were not going to mirror when the direction was related to navigation
Flags: needinfo?(swilkes)
Comment 6•10 years ago
|
||
Sam, you're correct. We're not going to change the spatial model aspects (per the bidi pattern) until we have more time to do it. It will be a lot of engineering effort, 2.3 or later.
Flags: needinfo?(swilkes)
Assignee | ||
Comment 7•10 years ago
|
||
I have a patch in progress with a little 'direction: ltr; unicode-bidi:embed;' action. Working on a marionette test.
Assignee: nobody → sfoster
Target Milestone: --- → 2.2 S2 (19dec)
Assignee | ||
Comment 9•10 years ago
|
||
I added the .nav class to help us distinguish navigation gaia-buttons from other instances - we only want the bottom navigation buttons to get fixed in LTR.
I did some backfill in the marionette tests while getting a test for this running. Its only kinda-related, could break it out into separate patch if preferred, but I don't think it does any harm.
Attachment #8532269 -
Flags: review?(fernando.campo)
Assignee | ||
Comment 10•10 years ago
|
||
Try is nice and green. Would be nice to land this. /me nudges fcampo
Flags: needinfo?(fernando.campo)
Comment 11•10 years ago
|
||
Comment on attachment 8532269 [details]
PR: Dont flip FTU nav buttons in RTL
Oooops! :( Sorry for delay, I started testing it on device, discovered that can't run any marionette test on it and got lost trying to fix that. But this tests pass nicely on local b2g and it's green, so I'm ok with adding language testing too, as it's not functionality we don't need a different pr.
Flags: needinfo?(fernando.campo)
Attachment #8532269 -
Flags: review?(fernando.campo) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Rebased and re-pushed. Lets see if autolander can do its thing
Whiteboard: [systemsfe] [checkin-needed]
Assignee | ||
Comment 13•10 years ago
|
||
Removing checkin-needed, want to double-check something...
Whiteboard: [systemsfe] [checkin-needed] → [systemsfe]
Assignee | ||
Comment 14•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 15•10 years ago
|
||
According comment 5&6&9
The bottom navigation buttons to get fixed in LTR.Now actual behavior is correct.
This issue verified successfully on Flame 2.2
Gaia-Rev f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID 20150119002502
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
Reprouce rate 0/5
Refer to Video VIDEO0261.mp4
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15449/
Flags: in-moztrap+
Comment 18•10 years ago
|
||
Lancy: TC is wrong. If you look at this bug comment 6 and onwards, as well as the last video that shows the fix, decision is that buttons should NOT be swapped in FTE. Please correct TC and any others that might contain this. thanks
Flags: needinfo?(yulan.zhu)
Comment 19•10 years ago
|
||
Here is the bidi pattern once more: https://mozilla.box.com/s/bcm3s5i2v6js5uk0ws3tsywse8bgncgo
Comment 20•10 years ago
|
||
The related test case has been modified correct.
Flags: needinfo?(yulan.zhu)
You need to log in
before you can comment on or make changes to this bug.
Description
•