Closed
Bug 103805
Opened 23 years ago
Closed 23 years ago
xpti needs support for 'additionalManagers'
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: jband_mozilla, Assigned: jband_mozilla)
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
dbradley
:
review+
vidur
:
superreview+
|
Details | Diff | Splinter Review |
The WebApps WSDL based SOAP support requires additional dynamic implementations
of nsIInterfaceInfoManager. In order to have a centralized place to *find* them
we decided to extend the singleton xpti service to also implement an interface
for adding, removing, and enumerating the additional dynamic implementations. We
want that collection point to support weak references. We anticipate the
posibility that other systems may also want to use that collection point.
I'll attach an untested implementation.
Assignee | ||
Comment 1•23 years ago
|
||
Updated•23 years ago
|
Attachment #52687 -
Flags: needs-work+
Comment 2•23 years ago
|
||
Comment on attachment 52687 [details] [diff] [review]
untested implementation
A couple of problems:
1) To get a weak reference, use do_GetWeakReference (which QIs to nsISupportsWeakReference and gets the weak reference from it).
2) enumerateAdditionManagers -> enumerateAdditionalManagers.
3) AppendElement on the enumerator class returns a PRBool, but you're treating it as a nsresult.
Assignee | ||
Comment 3•23 years ago
|
||
Thanks Vidur. Attaching new patch.
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #52687 -
Attachment is obsolete: true
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #52828 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.7
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #54026 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Comment 8•23 years ago
|
||
Comment on attachment 65110 [details] [diff] [review]
yet another refresh
sr=vidur
Attachment #65110 -
Flags: superreview+
Comment 9•23 years ago
|
||
Comment on attachment 65110 [details] [diff] [review]
yet another refresh
r=dbradley
I wanted to make sure I understood a couple of things. The additional managers
are held by the mAdditionalManagers array by weak references if they support
weak references, otherwise it's a norma ref counted pointer. And the
enumerator always has ref counted pointer to the managers, so that they're
guarenteed to be alive during the enumerators lifetime.
Attachment #65110 -
Flags: review+
Assignee | ||
Comment 10•23 years ago
|
||
Yes, exactly. Thanks.
Assignee | ||
Comment 11•23 years ago
|
||
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•