Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Description • 10 years ago

Current speech recognition API cannot specify media stream, we could introduce an optional parameter in SpeechRecognition.start() to enable following use cases:
  1. multiple microphone selection via gUM media constraints
  2. remote audio stream (WebRTC)
  3. stream from audio file

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 1 • 10 years ago

So the current spec doesn't support MediaStreams [1], but it definitely should and while the API
was designed, use of some sort of MediaStreams was discussed.
Could you file a spec bug about this[2].

[1] https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-section
[2] https://www.w3.org/Bugs/Public/enter_bug.cgi?product=Speech%20API

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 10 years ago

Comment on attachment 8455178 [details] [diff] [review]
speech-input-opt-stream.patch

The else {} in SpeechRecognition::Start could use a proper indentation.

	Guilherme Gonçalves [:ggp]
	Comment 3 • 10 years ago

Comment on attachment 8455178 [details] [diff] [review]
speech-input-opt-stream.patch

+1 on indentation, otherwise looks good to me.

Once we have this, it may also be possible to simplify our testing code, which uses a bit of a hack to inject a custom MediaStream into an existing SpeechRecognition object: http://dxr.mozilla.org/mozilla-central/source/content/media/webspeech/recognition/test/head.js?from=content/media/webspeech/recognition/test/head.js#120

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 4 • 10 years ago

Spec bug is filed: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26336

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 5 • 10 years ago

nit picked and update test cases.

try result:https://tbpl.mozilla.org/?tree=Try&rev=2074ce8e0d72

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 6 • 10 years ago

need bypass gum permission check for test_call_start_from_end_handler.html.

try result: https://tbpl.mozilla.org/?tree=Try&rev=251643e053b7

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 7 • 10 years ago

Comment on attachment 8455962 [details] [diff] [review]
speech-input-opt-stream.patch

ggp, please check the test changes

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 8 • 10 years ago

fix intermittent error on b2g emulator debug build by avoiding gUM in testcase, carry smaug's r+ and sr+.

try result: https://tbpl.mozilla.org/?tree=Try&rev=213dfd8f6324

	Guilherme Gonçalves [:ggp]
	Comment 9 • 10 years ago

Comment on attachment 8456672 [details] [diff] [review]
speech-input-opt-stream.patch

Looks good, thank you!

	Carsten Book [:Tomcat]
	Comment 10 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a038f26e9bbd

	Carsten Book [:Tomcat]
	Comment 11 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/a038f26e9bbd