Tzu-Lin Huang [:dwi2][:tzhuang] Reporter
	Description • 10 years ago

After bug 989198 lands, we should make UITest app to test this feature.

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 1 • 10 years ago

Steal this bug from dwi2, since he is busy on other issues.

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 2 • 10 years ago

According to wiki[1], I will add a page to uitest-privileged app to capture the following 4 keys and try to cancel them:

*. Power
*. Exit
*. VolumeUp
*. VolumeDown

The expected behavior is VolumeUp and VolumeDown can be intercepted by app and cancelled.

[1] https://wiki.mozilla.org/WebAPI/BrowserAPI/KeyboardEvent#Part_2_-_Key_event_handling_customization

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 3 • 10 years ago

A WIP patch can be found here:
https://github.com/huchengtw-moz/gaia/commit/abd347f400d9fed0cd3312954fe74cf8da7cf04e

This WIP patch depends on the patch of bug 1014418 and bug 989198.

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 4 • 10 years ago

Hi AlTasi,

This patch needs bug 1014418 and bug 989198 to work or we can build a workable version for you. Please give us some feedback.

	Jenny Liu[:jennyliu]
	Comment 5 • 10 years ago

Plan to land it by the end of v2.1 sprint 3 (August 29).

	Al Tsai [:atsai]
	Comment 6 • 10 years ago

A workable version of local build should be fine for me. I am still new to the project. Let me go to you for more details.

	Al Tsai [:atsai]
	Comment 7 • 10 years ago

Comment on attachment 8471451 [details]
patch for this bug

The patch seems good to me. Should I wait for the other two fixes for other bugs ready and execute testing?

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 8 • 10 years ago

Bug 989198 may need to refactor to fix a critical issue. I will create a workable version for you once it is ready.

	Kai-Chih Hu [:khu]
	Comment 9 • 10 years ago

Confirmed with EM/EPM, and this can be landed before FL.

	Kai-Chih Hu [:khu]
	Comment 10 • 10 years ago

It doesn't look like a strong need to be landed in 2.1 and also we already passed the feature landing date for 1 week. Postpone this to the next version for now.

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 11 • 10 years ago

atsai,

This PR is similar to the previous one. The difference is that we may need to focus the iframe while test opened. I recreate the PR because the previous one is closed by other guys.

Please review this patch.

BTW, the prevent default behavior is malfunction because of bug 1094066. We may use this to test that issue.

	Al Tsai [:atsai]
	Comment 12 • 10 years ago

Comment on attachment 8523726 [details]
patch for this bug

R=me. Good to merge.

	John Hu [:johnhu][:johu][:醬糊小弟] Assignee
	Comment 13 • 10 years ago

merged:
https://github.com/mozilla-b2g/gaia/commit/824a61cccec4c69be9a86ad5cb629a1f61fa142f