Closed Bug 1038254 Opened 10 years ago Closed 10 years ago

Clicking input field in 2.x Simulator for Windows crashes

Categories

(Firefox OS Graveyard :: Simulator, defect)

All
Windows 8.1
defect
Not set
normal

Tracking

(firefox32 wontfix, firefox33 wontfix, firefox34 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
Tracking Status
firefox32 --- wontfix
firefox33 --- wontfix
firefox34 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

(Keywords: crash)

Attachments

(1 file, 2 obsolete files)

STR: 1. Create a new app in WebIDE from the "Privileged Empty App" template 2. Add an text input field 3. Deploy to 2.x simulator 4. Click the input field... Crash! I'll attempt to get a debug simulator running so we can have a stack.
In bug 945152, support for memory-mapped array buffers was added, and that is used by the Keyboard app to load its dictionaries. However, that is not implemented on Windows for the moment (bug 988813). So for now, we should disable this by turning off the pref "dom.mapped_arraybuffer.enabled" on Windows.
Summary: Clicking input field in Simulator for Windows crashes → Clicking input field in 2.x Simulator for Windows crashes
Attached patch Disable memory-mapped array buffers on Windows (obsolete) (deleted) — Splinter Review
Fabrice, this disables memory-mapped array buffers on Windows, since they aren't implemented there currently (which in turn crashes the simulator when the keyboard opens). Try: https://tbpl.mozilla.org/?tree=Try&rev=f8a41ff42728
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8455697 - Flags: review?(fabrice)
Comment on attachment 8455697 [details] [diff] [review] Disable memory-mapped array buffers on Windows Review of attachment 8455697 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/app/b2g.js @@ +1016,2 @@ > pref("dom.mapped_arraybuffer.enabled", true); > +#endif Hm, that wont prevent crashes on other products... Can you instead set it to false by default in all.js and here just do: #ifndef XP_WIN pref("dom.mapped_arraybuffer.enabled", true); #endif
Attachment #8455697 - Flags: review?(fabrice)
Updated per review comments.
Attachment #8455697 - Attachment is obsolete: true
Attachment #8456410 - Flags: review?(fabrice)
Comment on attachment 8456410 [details] [diff] [review] Disable memory-mapped array buffers on Windows (v2) Review of attachment 8456410 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/app/b2g.js @@ +1008,5 @@ > > // Mobile Identity API. > pref("services.mobileid.server.uri", "https://msisdn-dev.stage.mozaws.net"); > > // Enable mapped array buffer nit: add a full stop at the end of the comment. ::: modules/libpref/src/init/all.js @@ +4218,5 @@ > > // DOM Inter-App Communication API. > pref("dom.inter-app-communication-api.enabled", false); > > +// Disable mapped array buffer by default nit: add a full stop at the end of the comment.
Attachment #8456410 - Flags: review?(fabrice) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Comment on attachment 8457714 [details] [diff] [review] Disable memory-mapped array buffers on Windows (v3, fabrice: r+) Approval Request Comment [Feature/regressing bug #]: bug 945152 did not account for b2g desktop on Windows [User impact if declined]: Text inputs crash the b2g 2.0 Simulator (which is built from the Aurora tree) on Windows [Describe test coverage new/current, TBPL]: on m-c [Risks and why]: Low, only toggling a pref [String/UUID change made/needed]: None
Attachment #8457714 - Flags: approval-mozilla-aurora?
Comment on attachment 8457714 [details] [diff] [review] Disable memory-mapped array buffers on Windows (v3, fabrice: r+) Approval Request Comment [Feature/regressing bug #]: bug 945152 did not account for b2g desktop on Windows [User impact if declined]: Text inputs crash the b2g 2.0 Simulator (which is built from the Beta tree) on Windows [Describe test coverage new/current, TBPL]: on m-c [Risks and why]: Low, only toggling a pref [String/UUID change made/needed]: None
Attachment #8457714 - Flags: approval-mozilla-beta?
Comment on attachment 8457714 [details] [diff] [review] Disable memory-mapped array buffers on Windows (v3, fabrice: r+) I confirmed with jryans that this change does not impact b2g devices. It is restricted to the simulator. B2G 2.0 is now on the b2g30 branch. Clearing the aurora and beta noms and approving for b2g32 (current 2.0 branch).
Attachment #8457714 - Flags: approval-mozilla-beta?
Attachment #8457714 - Flags: approval-mozilla-b2g32+
Attachment #8457714 - Flags: approval-mozilla-aurora?
I've now released Simulator builds 2.0.20140724 and 2.1.20140724 to resolve this issue.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: