Closed
Bug 1038288
Opened 10 years ago
Closed 10 years ago
Implement the updated InContent Preferences Design
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 34
People
(Reporter: Paenglab, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Bug for styling the updated InContent Preferences Design. For reference see attachment 8439538 [details].
|
Assignee | |
Comment 1•10 years ago
|
||
I removed the header icons and the 60px margin on the left like the mockup shows. I made the connected textbox and button generic to apply on all such elements (for example on Connections dialog in Advanced pane, when it land) like Chameleon wants it.
I also improved a little bit the margins of the in-content dialogs title and actionButtons but the fine finish of them will be done in bug 1036090.
Attachment #8455616 -
Flags: review?(jaws)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8455616 [details] [diff] [review]
updateInContentStyles.patch
Review of attachment 8455616 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Tested it on Windows7 Aero.
::: browser/themes/shared/incontentprefs/preferences.css
@@ +610,5 @@
> .fileFieldLabel {
> -moz-margin-start: -26px;
> -moz-padding-start: 36px;
> }
> +
nit, trailing space
Attachment #8455616 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Removed trailing space.
Attachment #8455616 -
Attachment is obsolete: true
Attachment #8461060 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Hi,
seems this patch didn't apply cleanly :
applying updateInContentStyles.patch
patching file browser/themes/shared/incontentprefs/preferences.css
Hunk #8 FAILED at 809
1 out of 8 hunks FAILED -- saving rejects to file browser/themes/shared/incontentprefs/preferences.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh updateInContentStyles.patch
could you look into this and resolve the conflict/maybe rebase against a current tree ? thanks!
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•10 years ago
|
||
Updated after bug 1035625 landing.
Attachment #8461060 -
Attachment is obsolete: true
Attachment #8461345 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•10 years ago
|
||
cool, thanks, did now the checkin!
|
|
||
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•