Closed
Bug 1038607
Opened 10 years ago
Closed 10 years ago
Unreadable text in search field on about:newtab page if using dark OS theme
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 33
People
(Reporter: seleznev.ru, Assigned: seleznev.ru)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
dao
:
review+
lmandel
:
approval-mozilla-beta+
lmandel
:
approval-mozilla-esr31+
|
Details | Diff | Splinter Review |
Just look on screenshot (bright text in search field and button).
Steps to reproduce:
1. Enable dark GTK+ theme (for ex., Xfce-dusk).
2. Open about:newtab page.
Assignee | ||
Comment 1•10 years ago
|
||
Just set #2e3436 color (default in gtk3 build + Adwaita theme) for GTK+ builds.
Attachment #8456033 -
Flags: review?(adw)
Comment 2•10 years ago
|
||
Comment on attachment 8456033 [details] [diff] [review]
Example patch
You should just use color:inherit here. Also, there's no reason why this should be Gtk-specific.
Attachment #8456033 -
Flags: review?(adw) → review-
Comment 3•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 8456033 [details] [diff] [review]
> Example patch
>
> You should just use color:inherit here.
Oops, I missed that the button has a white gradient as its background image. Since the gradient's opacity goes up to 80%, it might also make sense to use color:black here. (Although in practice it shouldn't matter since in this case color:inherit resolves to black anyway.)
OS: Linux → All
Summary: Unreadable text in search field on about:newtab page if using dark GTK+ theme → Unreadable text in search field on about:newtab page if using dark OS theme
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8456033 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 8456033 [details] [diff] [review]
> Example patch
>
> You should just use color:inherit here. Also, there's no reason why this
> should be Gtk-specific.
I updated example patch with account recommendations. But I am not sure that black color is good choice.
Comment 6•10 years ago
|
||
Reproduced on Firefox 31 beta 7 by using a High Contrast theme under Win 7, 64-bit.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•10 years ago
|
Attachment #8456064 -
Flags: review+
Comment 7•10 years ago
|
||
Thanks for the patch.
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Comment 11•10 years ago
|
||
Comment on attachment 8456064 [details] [diff] [review]
Example patch 2
(normally I would ask whoever on the desktop team was involved with a change about uplift, but Dão is on PTO and I think this is trivial and safe enough that I might as well just request uplift myself)
Approval Request Comment
[Feature/regressing bug #]: bug 962490
[User impact if declined]: unreadable new tab search box on certain OS themes
[Describe test coverage new/current, TBPL]: none
[Risks and why]: none, has lots of baking on nightly and now aurora, fix is specific to the buttons and input field on the new tab page
[String/UUID change made/needed]: none
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: unreadable text in primary UI, which has caused multiple people to file bugs
User impact if declined: see above.
Fix Landed on Version: 33
Risk to taking this patch (and alternatives if risky): none, see above
String or UUID changes made by this patch: none
See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8456064 -
Flags: approval-mozilla-esr31?
Attachment #8456064 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
status-firefox31:
--- → wontfix
status-firefox32:
--- → affected
status-firefox33:
--- → fixed
status-firefox-esr31:
--- → affected
Comment 12•10 years ago
|
||
Comment on attachment 8456064 [details] [diff] [review]
Example patch 2
Approved for beta and ESR31.
Attachment #8456064 -
Flags: approval-mozilla-esr31?
Attachment #8456064 -
Flags: approval-mozilla-esr31+
Attachment #8456064 -
Flags: approval-mozilla-beta?
Attachment #8456064 -
Flags: approval-mozilla-beta+
Comment 13•10 years ago
|
||
Comment 14•10 years ago
|
||
Verified fixed on Firefox Aurora, build ID:20140817004001 and Firefox 32 beta 8, build ID: 20140818191513.
The text from the search field is now visible (white) while using a dark theme.
Comment 15•10 years ago
|
||
Verified fixed on Firefox 31.1.0 ESR (buildID: 20140825060242).
You need to log in
before you can comment on or make changes to this bug.
Description
•