Closed
Bug 1038671
Opened 10 years ago
Closed 10 years ago
When the software home button is enabled we should ignore the hardware home button
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
People
(Reporter: etienne, Assigned: etienne)
References
Details
Attachments
(1 file)
We're going to do a fair amount of software home button work/dogfooding on flames which have a hardware home button so we want to make it as real as possible.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → etienne
Blocks: soft-home-button
Comment 1•10 years ago
|
||
Is this coupled with the developer setting?
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8456126 -
Flags: review?(21)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Gregor Wagner [:gwagner] from comment #1)
> Is this coupled with the developer setting?
Yes, it can be toggled from the settings app.
Attachment #8456126 -
Flags: review?(21) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Sorry here's the correct commit link:
https://github.com/mozilla-b2g/gaia/commit/c1a3adb4f922e2cc2c1fdd2746e13a20811e40e2
Comment 6•10 years ago
|
||
On the middle way of system 2 stuff and found this. Don't think it's a good way because people will think the hardware button is broken :/
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #6)
> On the middle way of system 2 stuff and found this. Don't think it's a good
> way because people will think the hardware button is broken :/
Let's discuss this, but some of the current software home work would be pretty impossible to work on without this. Especially software home + edge swipe work, especially on the flame.
Comment 8•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #6)
> On the middle way of system 2 stuff and found this. Don't think it's a good
> way because people will think the hardware button is broken :/
I second the idea that we should disable the hardware button if the user opt-in to the software one.
Comment 9•10 years ago
|
||
The issue is verified fixed in Flame 2.1 and Flame 2.2:
Flame 2.1 KitKat Base (319mb)(Full Flash)
Environmental Variables:
Device: Flame 2.1
BuildID: 20141007000203
Gaia: 7f738edf66b9298bceef8a4981d05d04fd04e540
Gecko: b9d04c58580a
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Flame 2.2 KitKat Base (319mb)(Full Flash)
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141007040205
Gaia: 83de447d9ae9a59459d7a445f9348a254c661850
Gecko: 9ee9e193fc48
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
The hardware home button is not working when the software home button is turned on.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1:
--- → verified
status-b2g-v2.2:
--- → verified
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•