Closed Bug 1038855 Opened 10 years ago Closed 10 years ago

SharedMemoryBasic fields should use nsRefPtr

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(3 files)

part 1 - Use an nsRefPtr for AsyncPanZoomController::mSharedFrameMetricsBuffer.
(deleted), patch
bjacob
: review+
Details | Diff | Splinter Review
part 2 - Use an nsRefPtr for CompositorChild::SharedFrameMetricsData::mBuffer.
(deleted), patch
bjacob
: review+
Details | Diff | Splinter Review
part 3 - Use an nsRefPtr for CrossProcessMutex::mSharedBuffer.
(deleted), patch
bjacob
: review+
Details | Diff | Splinter Review
SharedMemoryBasic inherits from SharedMemory, which is a refcounted class. CrossProcessMutex, CompositorChild::SharedFrameMetricsData and AsyncPanZoomController fail to do this.
This is all straightforward.
Attachment #8456521 - Flags: review?(bjacob)
hmm I'll ditch the |mBuffer = nullptr;| in the second patch...
Attachment #8456521 - Flags: review?(bjacob) → review+
Attachment #8456522 - Flags: review?(bjacob) → review+
Attachment #8456523 - Flags: review?(bjacob) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: