Closed
Bug 1039068
Opened 10 years ago
Closed 8 years ago
notifications.js leaks the most recently used notification <div>
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P3)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: khuey, Assigned: khuey)
References
Details
(Keywords: memory-leak, perf, Whiteboard: [MemShrink:P3][c=memory p= s= u=])
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8456584 -
Flags: review?(alive)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8456584 [details]
PR
Kyle, mind explaining? Not sure I understand it.
|
|
Assignee | |
Comment 3•10 years ago
|
||
In touchstart we set this._notification to the div that was touched.[0] That is cleared in swipeCloseNotification[1]. But tap() doesn't go through that.
The correct fix here may be to move clearing that from swipeCloseNotification to closeNotification, I'm not sure.
[0] http://mxr.mozilla.org/gaia/source/apps/system/js/notifications.js#189
[1] http://mxr.mozilla.org/gaia/source/apps/system/js/notifications.js#466
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8456584 [details]
PR
Etienne do you have better idea? I'm far away from this code base :P
Attachment #8456584 -
Flags: review?(alive) → review?(etienne)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8456584 [details]
PR
Yeah this code is pretty messy...
I think we should add a touchend listener on the container to do the cleanup.
I know there's a lot of memshrink work going on so feel free to re-assign the bug if needed.
Attachment #8456584 -
Flags: review?(etienne)
|
||
Updated•10 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P3]
|
||
Updated•10 years ago
|
|
||
Updated•10 years ago
|
Priority: -- → P3
|
||
Updated•9 years ago
|
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•