Krzysztof Mioduszewski[:tauzen] Assignee
	Description • 10 years ago

When NfcManager receives an NDEF message it parses the first record of the message and triggers the appropriate activity according to parsing result. NfcManager has several helper methods for different types of NDEF records, each of this methods performs suitable parsing and prepares options for activity to be launched.  

We should introduce an utility method which would parse NDEF record payload according to it's tnf and type. This method will be used by NfcManager the determine which activity should be triggered. 

This method will be also used by app developers to get the payload of other NDEF records from NDEF message. So they won't need to write the payload parsing code for common records themselves.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 1 • 10 years ago

Hi Greg, could you review this? There's a couple of changes here, so if you have any questions just let me know.

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 2 • 10 years ago

Comment on attachment 8464498 [details]
pull-request-1039245.txt

Hello, I think the patch is fine while the major change is to move the code around. Please fix the nits or comment on them and then checkin-needed.

	Krzysztof Mioduszewski[:tauzen] Assignee
	Comment 3 • 10 years ago

I've rebased the patch and fixed the comments from github as requested. Thanks for the review!

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/56878d8931a9f3fbb93ca284b6fc7d4384891816