Closed
Bug 1039326
Opened 10 years ago
Closed 10 years ago
[flatfish][settings] overlapping elements
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Firefox OS Graveyard
Gaia::Settings
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: abderahemane.benlamara, Assigned: chens)
References
Details
(Keywords: verifyme, Whiteboard: [Flatfish])
Attachments
(4 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243
Steps to reproduce:
settings elements are overlapping
FFos 2.1 flatfish_20140626-0139
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → shchen
Whiteboard: [Flatfish]
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8469127 -
Flags: feedback?(arthur.chen)
Assignee | ||
Comment 4•10 years ago
|
||
No, I didn't found it, do we have previous spec for slider on tablet that I can reference for?
Flags: needinfo?(shchen)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(arthur.chen)
Comment 5•10 years ago
|
||
Here is the latest tablet spec that I can find. Please adjust the UI based on the spec, thanks.
Flags: needinfo?(arthur.chen)
Assignee | ||
Comment 6•10 years ago
|
||
Update settings_large.css based on spec
Attachment #8469127 -
Attachment is obsolete: true
Attachment #8469127 -
Flags: feedback?(arthur.chen)
Attachment #8469967 -
Flags: feedback?(arthur.chen)
Comment 7•10 years ago
|
||
Comment on attachment 8469967 [details]
Pull request 2
Thanks for the patch! Please check my comment in github for a few tiny adjustments. And please also increase the width of select elements to make the default drop-down arrow invisible.
Attachment #8469967 -
Flags: feedback?(arthur.chen) → feedback+
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8469967 [details]
Pull request 2
Hi Arthur,
I have update the pull request based on the comments you shared, could you review this patch? thanks.
Attachment #8469967 -
Flags: review?(arthur.chen)
Comment 11•10 years ago
|
||
in this ticket there are other problem with alignment.
i've uploaded the images in the wrong ticket (-.-' too many tabs opened)
Comment 12•10 years ago
|
||
Comment on attachment 8469967 [details]
Pull request 2
Sorry for the late review. I thought I've had gave r+ on this one. r=me, thanks!
Attachment #8469967 -
Flags: review?(arthur.chen) → review+
Comment 13•10 years ago
|
||
I forget to mention the ticket with my screenshots https://bugzilla.mozilla.org/show_bug.cgi?id=1041313
Updated•10 years ago
|
Assignee | ||
Comment 14•10 years ago
|
||
(In reply to Daniele "Mte90" Scasciafratte from comment #13)
> I forget to mention the ticket with my screenshots
> https://bugzilla.mozilla.org/show_bug.cgi?id=1041313
Yep, also notice this, but we have bug 1041313 to track button related issues and we should work on that bug.
Comment 15•10 years ago
|
||
I have generated a pull request https://github.com/mozilla-b2g/gaia/pull/23245
Assignee | ||
Comment 16•10 years ago
|
||
Merged to master:
https://github.com/mozilla-b2g/gaia/commit/bfd676a58d172b16034610f4d274be14c4eee12a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•