Closed
Bug 1039493
Opened 10 years ago
Closed 10 years ago
Move debugger shell/settings to separate files
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Debugging code is cluttering up shell.js and settings.js. We can break this out into its own files.
Bug 942756 attachment 8415789 [details] [diff] [review] made an attempt at this, but the bug hasn't been updated for a while.
|
Assignee | |
Updated•10 years ago
|
Summary: Move debugger to separate files → Move debugger shell/settings to separate files
|
|
Assignee | |
Comment 1•10 years ago
|
||
Fabrice, I'm moving the DevTools related bits out of shell.js and settings.js.
Also, if it's okay with you, I thought it might be safe to only need DevTools peer review for future changes to the files in the new b2g/chrome/content/devtools directory, just to lighten the review burden. Either way, whatever's best for you.
Try: https://tbpl.mozilla.org/?tree=Try&rev=e29dd8dd3f52
|
||
Updated•10 years ago
|
Attachment #8474829 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 2•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
|
||
Comment 4•10 years ago
|
||
This breaks the screenreader, it is no longer activateable.
|
|
Assignee | |
Comment 5•10 years ago
|
||
(In reply to Eitan Isaacson [:eeejay] from comment #4)
> This breaks the screenreader, it is no longer activateable.
Sorry for the breakage. Looks like you've got a fix underway already.
You need to log in
before you can comment on or make changes to this bug.
Description
•