Closed
Bug 1039585
Opened 10 years ago
Closed 10 years ago
[Messages][Refactoring] Implement EventDispatcher object
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: azasypkin, Assigned: azasypkin)
References
Details
(Whiteboard: [sms-sprint-2.0S6])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
julienw
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details |
EventDispatcher object will help us to replace direct dependcies between components with publish/subscribe pattern.
Assignee | ||
Comment 1•10 years ago
|
||
Hey Julien,
Here is EventDispatcher that we have been discussing recently.
Thanks
Attachment #8456983 -
Flags: review?(felash)
Comment 2•10 years ago
|
||
Comment on attachment 8456983 [details]
GitHub pull request URL
looks good, let's do another round for the comments I made :)
Attachment #8456983 -
Flags: review?(felash)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8456983 [details]
GitHub pull request URL
(In reply to Julien Wajsberg [:julienw] from comment #2)
> Comment on attachment 8456983 [details]
> GitHub pull request URL
>
> looks good, let's do another round for the comments I made :)
Added second commit with suggested changes, thanks!
Attachment #8456983 -
Flags: review?(felash)
Assignee | ||
Updated•10 years ago
|
Blocks: sms-sprint-2.0S6
Whiteboard: [not-part-of-initial-sprint]
Comment 4•10 years ago
|
||
Comment on attachment 8456983 [details]
GitHub pull request URL
r=me with a green travis or gaia try
Attachment #8456983 -
Flags: review?(felash) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #4)
> Comment on attachment 8456983 [details]
> GitHub pull request URL
>
> r=me with a green travis or gaia try
Thanks for review!
Master: https://github.com/mozilla-b2g/gaia/commit/28911d958fc86d638a104923f9e39003fbcf080c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
No longer blocks: sms-sprint-2.0S6
Whiteboard: [not-part-of-initial-sprint] → [sms-sprint-2.0S6]
Comment 6•10 years ago
|
||
Comment on attachment 8456983 [details]
GitHub pull request URL
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: -
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low, the new code is not used anywhere yet
[String changes made]: none
We plan to use this new code in some 2.0+ blockers (especially some dependencies of bug 1038176)
Attachment #8456983 -
Flags: approval-gaia-v2.0?(lmandel)
Comment 7•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #6)
> [Testing completed]: yes
Especially this file is heavily unit tested.
Comment 8•10 years ago
|
||
Comment on attachment 8456983 [details]
GitHub pull request URL
Making an exception on approving a non 2.0+ bug this time given the risk is manageable and this is going to help critical blockers..
please back this out if there are any fallouts.
Attachment #8456983 -
Flags: approval-gaia-v2.0?(lmandel) → approval-gaia-v2.0+
Comment 9•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•