Closed Bug 1040548 Opened 10 years ago Closed 9 years ago

Move state (input sequence) out of IME engines and clean up the IME Engine API

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rudyl, Assigned: rudyl)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1038131 +++

This originated from bug 1038131 comment 10, that we should have a proper fix for bug 1015541.
 1. Should not have input sequence in latin IME, the state should be moved to keyboard module itself or have a separate "inputConnection" module.

 2. Should refine the IME APIs.

--
This may evolve into a meta bug, would try to do this with some small steps and get some integration tests ready first.
I really don't like this bug becoming a meta bug again -- we don't really need that much tracking bugs. But still I filed bug 1040603 to specify the first steps to do.

I don't think we could change a lot of IME API detail in neither of these two bugs. Let's do that else where.
Comment on attachment 8595313 [details]
[gaia] RudyLu:keyboard/Bug1040548-remove_input_sequence > mozilla-b2g:master

I think this is ready for review.

Tim, could you please help?
Thank you.
Attachment #8595313 - Flags: review?(timdream)
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Comment on attachment 8595313 [details]
[gaia] RudyLu:keyboard/Bug1040548-remove_input_sequence > mozilla-b2g:master

Nice work. Please make sure the performance does not regress.
Attachment #8595313 - Flags: review?(timdream) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: