Closed
Bug 1040641
Opened 10 years ago
Closed 10 years ago
Ignore AC_SUBSTs for variables we don't have use for but that autoconf itself exports
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6e653188b604
So the interestingly crazy thing here is that some of them we don't use at all (like FFLAGS), but some we do:
CFLAGS,
CXXFLAGS,
LDFLAGS,
LIBS
BUT for the first three, we actually reset them in config.mk, with the value of OS_*.
And guess what, OS_* is actually set to * in configure. (OS_CFLAGS=$CFLAGS, etc.). So for LIBS, which we don't reset in config.mk, we have redundancy between LIBS and OS_LIBS, which are both on the linker command lines... but sometimes we reset OS_LIBS with other values, so what's in LIBS is kept there, and what's in OS_LIBS is replaced.
This patch takes care of all instances of OS_LIBS being replaced by appending to it instead, and removes CFLAGS, CXXFLAGS, LDFLAGS, LIBS and a few more from autoconf.mk. Those variables can still however, be adjusted in backend.mk and Makefile, and still affect the linkage commands.
Attachment #8458530 -
Flags: review?(gps)
Updated•10 years ago
|
Attachment #8458530 -
Flags: review?(gps) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•