Closed
Bug 1040814
Opened 10 years ago
Closed 8 years ago
IonMonkey: Fold MTest to MGoto when both successors are the same block
Categories
(Core :: JavaScript Engine: JIT, enhancement, P5)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
People
(Reporter: sunfish, Unassigned)
References
Details
When range analysis deletes an unreachable block, as in
if (x > 0) {
if (x < 0) {
// unreachable
}
}
it is able to remove the unreachable code, however it leaves the outer (x > 0) branch behind, which becomes an MTest with both successors leading to the same block. MTest::foldsTo should ideally be able to check for this and fold the MTest into an MGoto.
|
||
Comment 1•8 years ago
|
||
From what I understood, when we remove a block from Range Analysis results, we go over GVN (which now includes UCE), and thus would make this bugs "RESOLVED FIXED" now. Is that right?
Flags: needinfo?(sunfish)
Priority: -- → P5
|
Reporter | |
Comment 2•8 years ago
|
||
Yes.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(sunfish)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•