Closed Bug 1040827 Opened 10 years ago Closed 7 years ago

System app keeps splash icons alive

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: BenWa, Unassigned)

References

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1040341 +++ (In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #3) > App Icons appears in the background of an application, when it is launched. > We can probably removed them once the app is loaded. I can confirm this. They are set in AppWindow.prototype.setFrameBackground. This bug should be about removing this icon once the app is launched. After you have a few apps started I see a MB or two used up by these icons. The system app, unlike the rest of b2g, keeps these images around much more aggressively so we need to be more diligent about removing them.
Summary: System app keeps many small images alive → System app keeps splash icons alive
Attached patch patch (deleted) — Splinter Review
This patch removes the image but I don't know the code enough to know if there's unwanted side effects. Can someone take this up and get it landed?
Whiteboard: [MemShrink] → [MemShrink:P2]
(In reply to Benoit Girard (:BenWa) from comment #1) > Created attachment 8458776 [details] [diff] [review] > patch > > This patch removes the image but I don't know the code enough to know if > there's unwanted side effects. Can someone take this up and get it landed? Alive, what do you think?
Flags: needinfo?(alive)
Sorry, but I cannot :( The icon is still necessary when doing swipe navigation; we should display the icon + name of the background app when we swipes. What we could do might be: drop the icon after mozbrowserloaded and re-render it on demand. Etienne how do you think?
Flags: needinfo?(alive) → needinfo?(etienne)
(In reply to Alive Kuo [:alive][NEEDINFO!][PTO until 9/9] from comment #3) > Sorry, but I cannot :( > The icon is still necessary when doing swipe navigation; > we should display the icon + name of the background app when we swipes. > > What we could do might be: drop the icon after mozbrowserloaded and > re-render it on demand. > Etienne how do you think? We could try, and figure out if it doesn't break the fast edge swipes to go through multiple apps. Benoit, do we need to remove the style.backgroundImage? Or can we just hide the identificationIcon? The container (.identification-overlay) is already be visibility:hidden. Should we use a real image tag?
Flags: needinfo?(etienne) → needinfo?(bgirard)
I believe if the style is removed from the DOM then the image should be discarded.
Flags: needinfo?(bgirard)
Closing out old Firefox OS specific memshrink bugs.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: