Closed Bug 1040875 Opened 10 years ago Closed 10 years ago

[Messages] Warning about failure to parse CSS value in delete messages view

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: khuey, Assigned: rishav_, Mentored)

References

Details

(Whiteboard: [sms-papercuts][good first bug][lang=js][mentor-lang=ru])

Attachments

(1 file)

STR: 1. Fire up SMS. 2. Select a conversation 3. Go to the ... menu and select Delete Messages In logcat you will see: [JavaScript Warning: "Error in parsing value for 'height'. Declaration dropped." {file: "app://sms.gaiamobile.org/index.html" line: 0 column 30 source: "calc(100% - undefinedpx - 50px)"}]
Kyle, can you please share your Firefox OS version? I think this might be fixed in v2.0, but I'd like to check that you're not using that version first :)
Flags: needinfo?(khuey)
(In reply to Julien Wajsberg [:julienw] from comment #1) > Kyle, can you please share your Firefox OS version? > > I think this might be fixed in v2.0, but I'd like to check that you're not > using that version first :) I think we still have this issue in master, since we're referring to "this.HEADER_HEIGHT" that we don't have anymore [1]. [1] https://github.com/mozilla-b2g/gaia/blob/ba1890064fc71651e4ee5db451183e4f0a180aec/apps/sms/js/thread_ui.js#L1855
Flags: needinfo?(khuey)
Ah yep, you're right. We should look whether this line is still useful then. I believe this is what made bug 1009098 in the first place and we use "direct" CSS to do this now.
Whiteboard: [sms-papercuts]
This was on master from sometime last week. I can give you a changeset hash if you really want it.
Mentor: azasypkin
Whiteboard: [sms-papercuts] → [sms-papercuts][good first bug][lang=js][mentor-lang=ru]
Assignee: nobody → rishav006
Hi Oleg This line is no more useful, since we're referring to "this.HEADER_HEIGHT" that we don't have anymore . Also this was blocking bug 829820. Have a look on attached PR. Thanks
Attachment #8494435 - Flags: review?(azasypkin)
Status: NEW → ASSIGNED
Comment on attachment 8494435 [details] Bug 1040875 - Warning about failure to parse CSS value in delete messages view Thanks for fixing this! Please add r=me to the commit message and "checkin-needed" keyword to the bug when you're ready!
Attachment #8494435 - Flags: review?(azasypkin) → review+
Blocks: 829820
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Summary: Warning about failure to parse CSS value in delete messages view → [Messages] Warning about failure to parse CSS value in delete messages view
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: