neil@parkwaycc.co.uk Assignee
	Description • 10 years ago

FakeString requires you to call SetCapacity(n + 1), SetLength(n), and then BeginWriting()[n] = char16_t(0). A real string does all this in one call to SetLength(n), and the calls to SetCapacity(n + 1) that are made on real strings could allocate more than necessary.

	neil@parkwaycc.co.uk Assignee
	Comment 2 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=37ba6f79c966

	Boris Zbarsky [:bzbarsky]
	Comment 3 • 10 years ago

Comment on attachment 8459150 [details] [diff] [review]
Proposed patch

>+    if (aLength < sInlineCapacity) {
>       SetData(mInlineStorage);
>     }
>+    else {

else goes up next to the '}'.

r=me with that, though this change will make bug 1025183 a bit more painful....

	neil@parkwaycc.co.uk Assignee
	Comment 4 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9350909a3401

	Jan de Mooij [:jandem]
	Comment 5 • 10 years ago

Thanks Neil! It was on my list (needinfo) but I didn't get to it yet.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/9350909a3401