Closed
Bug 1041155
Opened 10 years ago
Closed 10 years ago
The browser_wa_properties-view-media-nodes.js test doesn't wait for the audio device to be actually closed
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
4401 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-media-nodes.js | Found an unexpected Browser:WebRTCGlobalIndicator at the end of test run - Found an unexpected Browser:WebRTCGlobalIndicator at the end of test run
My patches from bug 1037408 and bug 1037430 got backed out due to this test failure. These bugs are important for Firefox 33 and contain localizable strings, so they should land before the next merge to Aurora (Monday).
I've been able to reproduce the failure with a local opt build on my Windows machine, and to write a fix (attached). I've pushed the attached patch to try: https://tbpl.mozilla.org/?tree=Try&rev=798e9b93af1f
Attachment #8459165 -
Flags: review?(vporof)
Attachment #8459165 -
Flags: review?(jsantell)
|
||
Updated•10 years ago
|
Attachment #8459165 -
Flags: review?(vporof)
Attachment #8459165 -
Flags: review?(jsantell)
Attachment #8459165 -
Flags: review+
|
||
Comment 1•10 years ago
|
||
Looks good to me
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•