Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Description • 10 years ago

Bug 762332 is about an assertion related to font inflation. We checked in a test that fails if the assertion goes away. For whatever reason, the assertion does not fire in e10s, so now the test is "failing". I'm not sure whether it would be better to skip running the test in e10s or to allow it to not assert. I chose the latter option in this patch. Either way, I just want to get e10s tests green.

	David Baron :dbaron:
	Comment 1 • 10 years ago

Comment on attachment 8459251 [details] [diff] [review]
font-test

Can you use asserts-if(!(condition-for-e10s),0-100) instead?

	Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Comment 2 • 10 years ago

Thanks, that's much nicer.

	David Baron :dbaron:
	Comment 3 • 10 years ago

Comment on attachment 8462885 [details] [diff] [review]
font-test v2

>-test-pref(font.size.inflation.emPerLine,15) asserts(1-100) load font-inflation-762332.html # bug 762332
>+test-pref(font.size.inflation.emPerLine,15) asserts(1-100) asserts-if(browserIsRemote,0-100) load font-inflation-762332.html # bug 762332

If it's reliably not asserting when browserIsRemote, you should instead change the line to:

>+test-pref(font.size.inflation.emPerLine,15) asserts-if(!browserIsRemote,1-100) load font-inflation-762332.html # bug 762332

that is, by making the existing asserts(1-100) conditional on !browserIsRemote.

r=dbaron with that

	David Baron :dbaron:
	Comment 4 • 10 years ago

(assertion ranges including both 0 and nonzero values are best avoided unless absolutely necessary, since they won't get removed when the underlying bugs are fixed, which means that we won't be protected from new assertions on those tests later)

	Bill McCloskey [inactive unless it's an emergency] (:billm) Assignee
	Comment 5 • 10 years ago

Thanks. Done.
https://hg.mozilla.org/integration/mozilla-inbound/rev/86f2f0f56aea

	Carsten Book [:Tomcat]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/86f2f0f56aea